diff --git a/Lib/test/test_struct.py b/Lib/test/test_struct.py index 0f3ac91a392..34abad55ea2 100644 --- a/Lib/test/test_struct.py +++ b/Lib/test/test_struct.py @@ -368,3 +368,28 @@ def run(self): ("qQ", 8)]: t = IntTester(*args) t.run() + + +########################################################################### +# The p ("Pascal string") code. + +def test_p_code(): + for code, input, expected, expectedback in [ + ('p','abc', '\x00', ''), + ('1p', 'abc', '\x00', ''), + ('2p', 'abc', '\x01a', 'a'), + ('3p', 'abc', '\x02ab', 'ab'), + ('4p', 'abc', '\x03abc', 'abc'), + ('5p', 'abc', '\x03abc\x00', 'abc'), + ('6p', 'abc', '\x03abc\x00\x00', 'abc'), + ('1000p', 'x'*1000, '\xff' + 'x'*999, 'x'*255)]: + got = struct.pack(code, input) + if got != expected: + raise TestFailed("pack(%r, %r) == %r but expected %r" % + (code, input, got, expected)) + (got,) = struct.unpack(code, got) + if got != expectedback: + raise TestFailed("unpack(%r, %r) == %r but expected %r" % + (code, input, got, expectedback)) + +test_p_code() diff --git a/Modules/structmodule.c b/Modules/structmodule.c index 46aa75bd53f..61436f92a8b 100644 --- a/Modules/structmodule.c +++ b/Modules/structmodule.c @@ -1360,6 +1360,8 @@ struct_pack(PyObject *self, PyObject *args) if (n < num) /* no real need, just to be nice */ memset(res+1+n, '\0', num-n); + if (n > 255) + n = 255; *res++ = n; /* store the length byte */ res += num; break;