David Anderson
f09166e5c4
client/Manager: show correct app version in multi-platform case
...
The GUI RPC element for a result didn't include the platform name.
So in cases where there were app versions with the same
version # and plan class (but different platforms)
the Manager would just show the first one
(e.g. the "executable file" item in Task Properties),
which was not necessarily correct.
2015-12-01 14:00:03 -08:00
Juha Sointusalo
1b18c7eeea
client(unix): fix VirtualBox detection
2015-11-26 23:36:41 +02:00
David Anderson
ef6c241587
client (Win): lowering I/O priority is an option rather than the default
...
Apparently even the thread-level version (SetThreadPriority())
caused the client to starve and become unresponsive if
something else was doing lots of disk I/O.
2015-11-25 00:52:54 -08:00
David Anderson
b5a4dd390c
client (linux): remove -n 7 in ionice call
2015-11-23 16:10:09 -08:00
Charlie Fenton
259ed89c46
client: Fix bug in detecting CUDA GPUs on Macs which was exposed by commits 7be9ff7
and d0005d7
.
2015-11-21 05:18:17 -08:00
Charlie Fenton
2df170ebda
client: Fix bug in detecting CUDA GPUs on Macs which was exposed by commits 7be9ff7
and d0005d7
.
2015-11-21 04:56:51 -08:00
David Anderson
24f62d0190
client, Win: use SetThreadPriority() to lower client priority
...
We had used SetPriorityClass() for this purpose,
but apparently this is too extreme,
and causes the client to run very slowly; see
http://stackoverflow.com/questions/13631644/setthreadpriority-and-setpriorityclass
2015-11-12 11:28:07 -08:00
David Anderson
3c8ceb028d
client: add config option to not lower client priority
...
We added code a couple of months ago to lower client priority:
on Win, this is SetPriorityClass(),
which lowers I/O and memory priority as well as CPU.
This has the desired effect, i.e. to reduce the performance impact
of BOINC when it's doing things like copying large files.
However, it means that BOINC can take a long time to start at boot,
which may be disconcerting to some users.
2015-11-11 10:33:24 -08:00
David Anderson
f525f0e8ba
client: remove CLIENT_STATE destructor; causes crash on Win
...
There's no reason to destruct anything; we're exiting.
2015-11-11 01:33:14 -08:00
David Anderson
314de0357a
client: show "wrong URL - reattach" message as a notice
2015-11-08 22:42:58 -08:00
David Anderson
86109b0815
client: work fetch backup-project tweak
...
The logic for backup projects (fetch for a resource only if idle instance)
was skipped in the case of GPU exceptions in my checkin of 10/10/2014.
I'm not sure why I did this, and it allows incorrect work fetch
in some cases, so I'm taking it out.
2015-11-07 20:48:02 -08:00
David Anderson
dde8233752
client: change quit/abort timeouts from 15 to 60 sec.
...
My last change handled only the client-exit case; need to handle all cases.
2015-11-07 16:06:54 -08:00
David Anderson
6708cb2f5d
client: use "1 CPU", ".5 CPUs", "2 CPUs".
2015-11-06 22:49:10 -08:00
David Anderson
f9900f07df
client: if app uses > 1 GPU, show them all in resource string
2015-11-04 15:57:54 -08:00
David Anderson
4f08492161
client: increase app-exit timeout from 15 to 60
...
This is the interval between when the client sends a "quit" message
to when it kills the app via TerminateProcess or SIGKILL.
Apparently VM apps that do their own state-saving
(i.e. that don't use snapshot-based checkpointing)
can take more than 15 seconds to do so.
Hopefully 60 is enough.
Rom suggested making this interval shorter in the case where
the OS is shutting down.
I don't think this is necessary since the OS kill everything anyway
after some period (5 sec in the case of Win 10).
2015-11-04 12:06:59 -08:00
Rom Walton
91147106f6
client: Fix build break on Windows
2015-10-28 13:58:42 -04:00
Christian Beer
9bbcf9a73a
initialize field in constructor
...
Coverity obviously can't handle structs that have the same name but are in two different components, so it showed this under Various and not Client.
fixes CID 27929 found by Coverity
2015-10-22 09:12:58 +02:00
Christian Beer
6a553cff2f
Merge branch 'master' into fix_coverity_defects
2015-10-22 08:38:21 +02:00
David Anderson
f0df42efbd
client (Unix): dlclose() dynamic libraries in GPU code
2015-10-21 08:34:02 -07:00
Christian Beer
6595ef0668
use snprintf to prevent buffer overflow
...
fixes CID 27937 found by Coverity
2015-10-20 19:42:52 +02:00
Christian Beer
970d4cf7b2
use snprintf to prevent buffer overflow
...
fixes CID 27973 found by Coverity
2015-10-20 19:31:51 +02:00
Christian Beer
cbbb2d738b
increase buffer size to fix string overflow
...
fixes CID 27885 found by Coverity
2015-10-20 19:29:48 +02:00
Christian Beer
bde03875cc
delete object before going out of scope
...
fixes CID 27746 found by Coverity
2015-10-20 18:49:29 +02:00
Christian Beer
79134f3a4a
delete objects in deconstructor
...
fixes CID 27694, 27712 found by Coverity
2015-10-20 18:35:55 +02:00
Christian Beer
c4ba2d2ca8
initialize fields in constructors
...
fixes CID 27958 found by Coverity Scan
2015-10-20 17:51:46 +02:00
Christian Beer
9ffe92f7d1
initialize fields in constructors
...
fixes missing initialization found by cppcheck
2015-10-20 17:47:59 +02:00
Christian Beer
0ce3f7d996
initialize fields in constructors
...
fixes CID 27955 found by Coverity Scan and cppcheck
2015-10-20 17:46:59 +02:00
Christian Beer
4e909c67ef
initialize fields in constructors
...
fixes CID 28033 found by Coverity Scan and cppcheck
2015-10-20 17:16:04 +02:00
Christian Beer
dd6f9c3ac6
initialize fields in constructors
...
fixes CID 27926, 28022 found by Coverity Scan and cppcheck
2015-10-20 16:47:36 +02:00
Christian Beer
0b3a760924
initialize fields in constructors
...
fixes CID 27984 found by Coverity Scan
2015-10-20 15:58:34 +02:00
Christian Beer
15bdf95269
initialize fields in constructors
...
fixes CID 27990 found by Coverity Scan
2015-10-20 15:31:58 +02:00
Christian Beer
5027e948d4
initialize fields in constructors
...
fixes CID 27927 found by Coverity Scan
2015-10-20 15:27:36 +02:00
Christian Beer
2a09622b5f
initialize fields in constructors
...
fixes CID 28006 found by Coverity Scan and cppcheck
2015-10-20 15:23:25 +02:00
Christian Beer
9e0e1dd997
initialize fields in constructors
...
fixes CID 28039 found by Coverity Scan and cppcheck
2015-10-20 15:05:21 +02:00
Christian Beer
676b650570
initialize fields in constructors
...
fixes defect found by cppcheck
2015-10-20 14:17:52 +02:00
Christian Beer
96ae6e5c98
initialize fields in constructors
...
fixes CID 28030 found by Coverity Scan
2015-10-19 18:46:14 +02:00
Christian Beer
1114cc7878
initialize fields in constructors
...
fixes CID 27980 found by Coverity Scan
2015-10-19 18:35:36 +02:00
Christian Beer
9c7bf33c45
initialize fields in constructors
...
fixes CID 27935, 28004 and 27948 found by Coverity Scan
2015-10-19 18:23:55 +02:00
Christian Beer
d13c217628
initialize fields in constructors
...
fixes CIDs 27915 and 28013 found by Coverity Scan
2015-10-18 22:25:31 +02:00
Christian Beer
fb715ed47b
initialize fields in constructors
...
fixes CIDs 27934 and 27943 found by Coverity Scan
2015-10-18 22:23:05 +02:00
Christian Beer
d5fcef3cd9
initialize fields in constructors
...
fixes CID 27914, 28007 and 28034 found by Coverity Scan
2015-10-18 20:56:48 +02:00
David Anderson
d2c91e16dd
client, condor, remote submit: fix a few Coverity warnings
2015-10-14 10:29:15 -07:00
David Anderson
1a9fc11f29
client: tweak to remove Coverity warning
2015-10-14 01:29:30 -07:00
David Anderson
259a0d1732
client: print network suspend reasons as strings
2015-10-12 14:48:03 -07:00
Julien Nabet
78e0a8a2b7
cppcheck: Fix reports "Prefer prefix ++/-- operators for non-primitive types"
...
[client/app.cpp:313]: (performance) Prefer prefix ++/-- operators for non-primitive types.
[client/result.cpp:693]: (performance) Prefer prefix ++/-- operators for non-primitive types.
2015-10-10 21:22:18 +02:00
David Anderson
0a74e7fe0d
client: GPU name tweak
2015-10-02 00:10:18 -07:00
David Anderson
5c0ec94544
client: updated AMD GPU names, from Jord
2015-10-01 16:42:42 -07:00
David Anderson
0a9a982310
Merge branch 'master' of github.com:BOINC/boinc
2015-09-29 22:41:40 -07:00
David Anderson
517cc53c67
client: add separate config item for process priority of GPU/NCI/wrapper jobs
2015-09-29 22:40:40 -07:00
David Anderson
a1876e3257
client: fix typo
2015-09-29 13:47:48 -07:00