No need to pass a member variable to a member function.
Also: fix confused variable names: "current_cpu_time" is just this episode.
"total_cpu_time" is total since start of job.
Also: fix code formatting.
This was complicated by the fact that VBox changed the API a little:
GetChildrenCount() is now get_ChildrenCount(),
and CreateSharedFolder() takes a new AutoMountPoint argument
(where the folder goes in the guest system) which I'm assuming should be /.
I handled these using #ifdefs in vbox_mscom_impl.cpp.
used by LHC@home
modifications that have been included in the version that is currently used from LHC@home
fix compatibility issue caused by C++98 compiler used by travis
there is no real reason to delete it piece by piece
first. VirtualBox takes care of deleting everything.
Mentioning something that is already deleted results in
unexpected behavior (ghost mediums)
remove ghost mediums from the media registry
deleted comments and commands
From PVS Studio:
V808
'vm_machine_uuid' object of 'CComBSTR' type was created but was not utilized.
'clean_mediums' object of 'vector' type was created but was not utilized.
https://www.viva64.com/en/w/V808/print
Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
From PVS Studio:
V501:
'There are identical sub-expressions 'enable_isocontextualization' to the left and to the right of the '&&' operator.'
https://www.viva64.com/en/w/V501/print/
Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
VS lets you choose the compiler warning level, 0 to 4.
Higher is good because compiler warnings often indicate bugs.
However, some warnings are noise, and having a lot of them is bad
because they conceal the important ones.
As an example, a recent update to VS2010 causes it to spew warnings of the form
"function _strdup() is deprecated; use _strdup() instead.
So the new policy is:
- everything compiles with warning level 4
- in boinc_win.h we use #pragmas to suppress 3 specific warnings
that occur a lot in our code, and are not bugs:
- the _function names as described above
- constant conditional expression (like while(1))
- conversion from int to char
And the goal is to build everything with zero warnings
except from outside code like zip.
We're pretty close to that.
The project files for other VS versions should be modified
to also use level 4 everywhere.
Tells vboxwrapper to copy its cmdline args to shared/cmdline.
This lets you use the cmdline mechanism as a way to pass
info to the VM that would otherwise have to go in a file.
Note: the cmdline can be fairly large.
It shares the wu.xml_doc field with file descriptions.
This field can be up to 64KB (MySQL blob size)
Vitalii Koshura