Commit Graph

744 Commits

Author SHA1 Message Date
Oliver Bock e2f0f1b9fd Drupal: harden team email list RPC wrapper 2016-11-09 14:58:17 +01:00
Tristan Olive eed66cc916 Drupal: Fix additional omission in signature display logic
Commit 891537c restored functionality inadvertently removed by f64e644, but lacked global declaration of the $user object, so didn't quite work as expected; adding this declaration ensures that the $user object (and thus the current user's preferences) are referenced in the proper scope
2016-11-04 11:32:07 -04:00
Christian Beer 891537cfe1 Drupal: show signatures in comments again
Commit f64e644f inadvertently removed a crucial line that prevents signatures from being shown. I also got rid of the commented out comment that gave the impression that this function is not used.
2016-11-03 14:03:27 +01:00
Shawn Kwang 7bdc66ef8a Drupal: Changed order of comment/forum topic links.
Edit link has been moved into the standard user links. Moderator/Admin links have been reordered.
In addition, some indent and whitespace changes to match Drupal coding standards.

https://dev.gridrepublic.org/browse/DBOINCP-334
2016-11-02 09:43:13 -05:00
tristanolive be18e67fae Merge pull request #1694 from drshawnkwang/drupal_fix-bugforumread
Drupal: Fix bug where "Mark forums as read" link led to Access Denied.
2016-11-01 16:11:47 -04:00
tristanolive f1da9e882c Merge pull request #1693 from drshawnkwang/drupal_fix-teampanel
Drupal: Fix bug where team view panel could view any node.
2016-11-01 16:10:34 -04:00
Shawn Kwang 384f527758 Drupal: Fix bug where team view panel could view any node.
Added test to make sure node content is of type==team.

https://dev.gridrepublic.org/browse/DBOINCP-333
2016-11-01 14:21:11 -05:00
Shawn Kwang 0f263df9ee Drupal: Modified CSS to adjust space around comment links. 2016-11-01 13:52:19 -05:00
Shawn Kwang 2f5dcd0157 Drupal: Reordered comment links, new function to add "first" to moderator links.
Reorders comment links, standard links have QUOTE and REPLY first, followed by the flag-abuse links.
Created private function to add class "first" to first moderator link. This is used because the links are split now manaully split by the theme.
2016-11-01 13:49:39 -05:00
Shawn Kwang 1c11997f6a Drupal: Fix bug where "Mark forum as read" link led to Access Denied.
https://dev.gridrepublic.org/browse/DBOINCP-332
2016-11-01 11:34:49 -05:00
Shawn Kwang ec3dd7f705 Drupal: Fix bug- when no $links are generated, the function _boinc_create_moderator_links() should exit without doing anything.
https://dev.gridrepublic.org/browse/DBOINCP-316
2016-10-31 08:03:53 -05:00
tristanolive 5040694dfb Merge pull request #1690 from drshawnkwang/drupal_fix-ahahformcancel
Drupal: Fix bug where Cancel link in AHAH form
2016-10-27 10:30:20 -04:00
tristanolive 2cf8c8ec6b Merge pull request #1685 from drshawnkwang/drupal_fix-prefscustom
Drupal: Fixed bug where user cannot select preset radio button.
2016-10-27 10:29:51 -04:00
Tristan Olive 9a79faf523 Drupal: Fix typo in comment 2016-10-27 09:50:26 -04:00
Tristan Olive ecc6a47bd6 Merge branch 'drupal_feature-commentperm' of https://github.com/drshawnkwang/boinc into drshawnkwang-drupal_feature-commentperm 2016-10-27 01:52:09 -04:00
Shawn Kwang 33a811e83b Drupal: Fix bug where Cancel link in AHAH form resulting in wrong page loading.
Changed cancel link from current URL to a pre-defined URL, the computing preference edit page.

https://dev.gridrepublic.org/browse/DBOINCP-307
2016-10-26 12:31:37 -05:00
Shawn Kwang 0e2bf5b072 Drupal: Fixed bug where user cannot select preset radio button.
Also fix bug where user can have <preset> tag set from another project. Upon initial loading of the preferences form, the preferences are filled from the user's database entry.

https://dev.gridrepublic.org/browse/DBOINCP-325
2016-10-21 14:01:28 -05:00
Tristan Olive 60eac4d63f Merge branch 'drupal_fix-removeprefsviewpage' of https://github.com/drshawnkwang/boinc into drshawnkwang-drupal_fix-removeprefsviewpage 2016-10-20 16:11:56 -04:00
Tristan Olive e9fc311f3d Merge branch 'drupal_fix-prefmodtime' of https://github.com/drshawnkwang/boinc into drshawnkwang-drupal_fix-prefmodtime 2016-10-20 16:02:04 -04:00
Shawn Kwang cbea11085b Drupal: Fixed bug- Post New Topic link only appears to team members, even in a Public team forum. 2016-10-20 13:48:21 -05:00
Shawn Kwang 5cc7545f10 Drupal: Fixed bug- user can now edit their own team forum topics.
https://dev.gridrepublic.org/browse/DBOINCP-319
2016-10-20 13:47:47 -05:00
Shawn Kwang a4fced6723 Drupal: Changed forum_access install schema to use type unsigned int for field 'rid'.
https://dev.gridrepublic.org/browse/DBOINCP-324
2016-10-20 11:39:41 -05:00
Shawn Kwang c93a6f24cf Drupal: Removed view page/option from project preferences.
https://dev.gridrepublic.org/browse/DBOINCP-327
2016-10-20 08:18:37 -05:00
Shawn Kwang 4e9ebe7028 Drupal: Removed view page/option from computing/general preferences.
https://dev.gridrepublic.org/browse/DBOINCP-327
2016-10-20 08:17:27 -05:00
tristanolive cbaee94231 Merge pull request #1681 from drshawnkwang/drupal_fix-venueupdate
Drupal: Fixed udpate venue issue.
2016-10-20 00:34:30 -04:00
tristanolive 11c5d94502 Merge pull request #1679 from drshawnkwang/drupal_feature-dbcompmore
Drupal: Changed More (computers) link on Account Dashboard.
2016-10-20 00:09:44 -04:00
Shawn Kwang b909e2ae06 Drupal: Fixed udpate venue issue.
function venue_update() no longer exists in BOINC code. Changed to boincwork's boincwork_set_default_venue() function.

https://dev.gridrepublic.org/browse/DBOINCP-311
2016-10-19 15:49:45 -05:00
Shawn Kwang 360ab96348 Drupal: Fixed bug where last modification time of preferences was not being displayed correctly on preferences combined-table page.
https://dev.gridrepublic.org/browse/DBOINCP-305
2016-10-19 14:33:35 -05:00
Shawn Kwang e5c5bfe4fa Drupal: Create intermediate variable to suppress error message in log. 2016-10-19 12:25:22 -05:00
Shawn Kwang bf4c8bfa9a Drupal: Fixed two bugs in boinccode and removed commented out code. 2016-10-19 12:01:02 -05:00
Shawn Kwang f64e644fe5 Drupal: Changes to boinc theme regarding how links are generated.
boinccore_link() and boinccore_link_alter() are now responsible for adding links to forum topics (and team forum) and comments in order. This has been moved from the boinc theme template.php.
Now template.php contains a function to split the links string into two strings: links and moderator_links which duplciates the old functionality where the theme generated these two sets of links.
2016-10-19 11:59:28 -05:00
Shawn Kwang ac8426490a Drupal: Added functionality in forum_access module to remove certain links depending on permissions. 2016-10-19 09:18:49 -05:00
Shawn Kwang d69722ea22 Drupal: Changed link from Account Dashboard.
Was: account/computers/all
Now: account/computers

https://dev.gridrepublic.org/browse/DBOINCP-326
2016-10-14 14:41:12 -05:00
Shawn Kwang 3cbe0f9036 Drupal: Fix bug where custom preferences from other projects were not being displayed in the Web form correctly.
Other BOINC projects may not use the <preset> tag, which we introduced recently.

https://dev.gridrepublic.org/browse/DBOINCP-325
2016-10-14 14:29:18 -05:00
Shawn Kwang 0758c2b7fa Drupal: Added functionality where a user cannot access a forum directly via its URL. They will reach an Access Denied page if they do not have grant_view permissions. 2016-10-13 15:04:11 -05:00
Shawn Kwang f4d64f73c3 Drupal: Updated forum_access info file to reflect new version. 2016-10-13 14:25:54 -05:00
Shawn Kwang 029a2574f0 Drupal: Additional code for forum_access module.
Fixed bug where comment permission was not being saved.
Changed error messages for user if comments are not allowed.
2016-10-13 14:24:51 -05:00
tristanolive 7185bfd993 Merge pull request #1669 from drshawnkwang/drupal_fix-workunitview
Drupal: Fix workunit view for adaptive replication
2016-10-12 13:36:53 -04:00
tristanolive 9ce8ed61d2 Merge pull request #1668 from drshawnkwang/drupal_feature-pref-usestandard
Drupal: default preference set is now 'standard'.
2016-10-12 13:27:05 -04:00
Shawn Kwang c834162832 Drupal: Added comment_create grant type to contrib forum access module.
Backported code for forum_access module, from D7 patch. Allows admin to control separately the permissions of creating a forum post and creating forum comment on a post.

https://dev.gridrepublic.org/browse/DBOINCP-316
2016-10-11 15:30:20 -05:00
Shawn Kwang f23e657b72 Drupal: Fixed bug where team forum Last post was incorrect.
On main forum page, the team forum Last post field was wrong. I fixed the DB query to return the correct timestamp.

https://dev.gridrepublic.org/browse/DBOINCP-321
2016-10-11 11:33:40 -05:00
Shawn Kwang 739898ffdc Drupal:
Fixed bug: Removed admin-only message which was being displayed to user. Now only admin knows whether or not preference presets are present in the drupal database.
Fixed bug: Removed else clause which was unnecessary, switch statement does the equivalent.
Fixed bug: statically called function removed; prevents PHP error messages in drupal log.
Text for admin editted to be slighly better.
2016-10-06 12:20:39 -05:00
Shawn Kwang c2120b9349 Drupal: Fix workunit view- suppress output if app is using adaptive replication
Fixed wrong variable name in view.
Added additional conditional logic using a) error_mask and b) config.xml <dontsupressoutput> setting to match BOINC code. This is to suppress output if the app uses adaptive replication.
(b) is obtained through a new field in the fiew which loads the setting from config.xml into a variable.

Changed workunit view template. Variables from view used to determine if task list is output.

https://dev.gridrepublic.org/browse/DBOINCP-255
2016-10-06 10:59:42 -05:00
tristanolive c43dd719bc Merge pull request #1666 from drshawnkwang/drupal_fix-cssstickyheader
Drupal: Fixed CSS style for stick-header
2016-10-06 00:03:24 -04:00
tristanolive d621bb0896 Merge pull request #1665 from drshawnkwang/drupal_feature-fa-teamforums
Drupal: Add icons to team forums
2016-10-05 23:57:52 -04:00
Tristan Olive 82aad74875 Merge branch 'drupal_fix-teamforum-miscandcss' of https://github.com/drshawnkwang/boinc into drshawnkwang-drupal_fix-teamforum-miscandcss 2016-10-05 23:11:01 -04:00
Shawn Kwang 63f40afdc8 Drupal: default preference set is now 'standard'.
The default preference set when a user visits the accounts preference page is 'standard'.

Added form submit for BOINC: preferences preset admin interface. Admin may now save configuration with the disk usage settings from config.xml. In this way, those XML settings will be loaded into the database as the default preferences presets. These presets are in turn used by drupal when the user visits the preferences page. The form on that page will be filled with the preferences from the drupal database.

If there are no preference preset loaded in the drupal database, then the standard preset will be filled in with the disk usage settings from config.xml. Once it is save into the drupal database, the admin must use the Save configuration with disk usage settings from config.xml button in order to reload the disk usage settings from config.xml again.

https://dev.gridrepublic.org/browse/DBOINCP-310
2016-10-05 13:21:18 -05:00
Shawn Kwang 5d0d6b43cc Drupal: Fixed CSS style so sticky-header has same CSS as main table header.
https://dev.gridrepublic.org/browse/DBOINCP-313
2016-09-30 17:42:20 -05:00
Shawn Kwang 856a3c21bd Drupal: Added font-awesome icons to team-forum topic-list.
https://dev.gridrepublic.org/browse/DBOINCP-315
2016-09-30 14:02:28 -05:00
tristanolive 3cc07a5bc1 Merge pull request #1663 from drshawnkwang/drupal_feature-remove-autosave-preferences-2
Drupal: Removed autosave from prefrences page
2016-09-29 16:38:35 -04:00