Rooba
/
boinc
mirror of https://github.com/BOINC/boinc.git
1
0
Fork 0
Code Issues 1 Packages Projects Releases Wiki Activity
34,124 Commits 93 Branches 867 Tags 348 MiB
Commit Graph

45 Commits

Author SHA1 Message Date
Vitalii Koshura 7b3a683f68
Merge pull request #3168 from BOINC/cb_fix_small_issues 
Quality: fix small issues
 2019-06-27 15:32:02 +02:00
David Anderson 3271148607 vboxwrapper: fix shadowed-var compile warnings. 
No need to pass a member variable to a member function.

Also: fix confused variable names: "current_cpu_time" is just this episode.
"total_cpu_time" is total since start of job.

Also: fix code formatting.
 2019-06-09 23:19:48 -07:00
Christian Beer 24c307a1c4 Vboxwrapper: initialize class members 
found by Coverity (CIDs 278299 34531)
 2019-05-28 21:21:13 +02:00
Rytis Slatkevičius eb829b65d9
Typo fix in vbox_common.cpp 
Just a typo in one word
 2019-05-07 10:26:48 +03:00
nikolasgianna 841e4f2b90 Implementation of changes requested 2017-11-06 14:59:59 +01:00
nikolasgianna 2cc8aa1715 Declare state variable within respective function 2017-09-28 09:22:39 +02:00
nikolasgianna 3e9b731f17 Update online and saving in stop() and poweroff(), fix CamelCase 2017-09-27 10:45:49 +02:00
nikolasgianna e8777ff60b Transform state from vm log to lowercase and fix never reached if 2017-09-26 13:53:35 +02:00
nikolasgianna 79c0e75f0c fix indentation, pointers, sscanf, get_vm_process_id, dump_vmguestlog_entries 2017-06-21 16:22:46 +02:00
nikolasgianna 8ac79a370c Merge branch 'master' into prod_version 2017-06-21 14:53:48 +02:00
nikolasgianna 9d8abbb5f0 fix indentation, pointers, sscanf, get_vm_process_id, dump_vmguestlog_entries 2017-06-21 14:24:01 +02:00
nikolasgianna 945035d3f1 version and error displaying improvements 2017-06-20 17:18:07 +02:00
nikolasgianna 906481fb64 modifications that have been included in the version that is currently 
used by LHC@home

modifications that have been included in the version that is currently used from LHC@home

fix compatibility issue caused by C++98 compiler used by travis
 2017-06-20 13:25:04 +02:00
nikolasgianna 2b4605c5cb Fix indentation 2017-04-18 09:58:21 +02:00
nikolasgianna 2420c31902 Give choice between COM and VboxManage interface 2017-04-10 10:50:42 +02:00
David Anderson ca80cac75a Win build: manage compiler warnings better: 
VS lets you choose the compiler warning level, 0 to 4.
Higher is good because compiler warnings often indicate bugs.
However, some warnings are noise, and having a lot of them is bad
because they conceal the important ones.
As an example, a recent update to VS2010 causes it to spew warnings of the form
"function _strdup() is deprecated; use _strdup() instead.

So the new policy is:
- everything compiles with warning level 4
- in boinc_win.h we use #pragmas to suppress 3 specific warnings
  that occur a lot in our code, and are not bugs:
  - the _function names as described above
  - constant conditional expression (like while(1))
  - conversion from int to char

And the goal is to build everything with zero warnings
except from outside code like zip.
We're pretty close to that.

The project files for other VS versions should be modified
to also use level 4 everywhere.
 2017-01-27 01:27:32 -08:00
David Anderson 56d59a7780 vboxwrapper: fix bugs in cmdline memory size spec; fix compile warnings 2016-07-01 12:06:55 -07:00
Rom Walton c01f534595 VBOX: Formatting changes to stderr log 2016-06-14 10:02:51 -07:00
Rom Walton 5480ff4a9d VBOX: Screen shots can only be taken while the VM is running and we hold the session lock. Make sure we take them before attempting to clean-up. 2016-06-13 09:49:07 -07:00
Rom Walton d5c3142993 VBOX: Bug fixes for previous commit. 2016-06-12 22:02:10 -07:00
Rom Walton 9dad26fefb VBOX: Take a screen shot on failure and dump the base64 encoded image to stderr. 
Report the MD5 signature in the stderr output as well so that duplicate screen shots can be quickly identified.  Of course this assumes that the exact same PNG is generated across different machine types and video cards.  Currently I believe that it should given the hardware in question is virtualized.
 2016-06-12 19:20:55 -07:00
Rom Walton fbb8e0dc09 VBOX: Attempt to read VirtualBox logs in-place to cut down on disk I/O. 2015-10-11 13:27:03 -04:00
Rom Walton 0ee90d7995 VBOX: Update CPU VMX/SVM usage detection code with the latest error messages returned by VirtualBox 5.x 2015-10-09 12:38:28 -04:00
Rom Walton f9279627f9 VBOX: Fix build break when building a debug version of vboxwrapper 2015-09-29 16:57:23 -04:00
Rom Walton eaf9cb817d VBOX: Only perform the printf format string sanitize functionality on those strings that are going to be consumed by vbox_log(). 2015-08-28 17:24:00 -04:00
Rom Walton 6736f5958e VBOX: Add additional comments 2015-08-28 17:16:13 -04:00
Rom Walton 54a2715e8f VBOX: Possible fix for endless loop. 2015-08-28 16:01:48 -04:00
Rom Walton 38d8041523 VBOX: Bug fix for previous commit. 2015-08-28 14:25:37 -04:00
Rom Walton bbd94c4b7d VBOX: Sanitize 'Guest Log' entries before attempting to write them to stderr. 2015-08-28 14:23:45 -04:00
Rom Walton 3ee10705e8 VBOX: Clean-up the VirtualBox version detection mess. 2015-07-05 14:35:48 -04:00
Rom Walton d57ba52623 VBOX: Introduce the notion of a scratch directory when shared folders are used. 
The scratch directory is created under the project folder.
 2015-06-25 19:16:10 -04:00
Rom Walton b109e0a3a7 VBOX: Make sure to include the startup log in stderr instead of just repeating the trace log. 2015-04-15 12:47:54 -04:00
Rom Walton 28254563da VBOX: Always show the VboxStartup.log on error. 2015-04-13 13:05:11 -04:00
Rom Walton 19b3dd982b VBOX: Add VboxStartup.log to the list of partial log dumps to stderr when something goes wrong. 2015-04-08 12:52:59 -04:00
Rom Walton 8433264ed2 VBOX: cut down on some of the noise with spurious 'Status Report' messages when we attempt to launch the VM. 2015-04-07 19:58:39 -04:00
Rom Walton 9dc2161436 VBOX: Configure a bunch of virtual functions to be purely abstract to avoid a bunch of compiler warnings in gcc 2015-01-15 18:14:35 -05:00
Rom Walton 91bb400ce1 VBOX: Bug fix for persisting remote desktop/web api port information 2014-12-31 03:11:21 -05:00
Rom Walton 58fcffc859 VBOX: Refactor vboxwrapper to streamline logging and prepare for vboxhtmlgfx. 2014-12-19 09:55:48 -05:00
Rom Walton cb6c328151 VBOX: Make the vboxmanage interface work on Windows again. 
VBOX: Make the service install scenario work again.
 2014-11-23 23:22:57 -05:00
Rom Walton 18abc0db07 VBOX: Get rid of unneeded variables 2014-11-23 12:47:37 -05:00
Rom Walton a09b30353f VBOX: Cleanup error handling code, remove duplication. 2014-11-23 12:47:37 -05:00
Rom Walton 85f364485c VBOX: When checking for the existence of a VM registered to a given slot directory, also check for the ISO Contextualization image and cache disk image. If any type of media is registered to a given slot directory, close it regardless if it is attached to a VM or not. 2014-11-23 12:47:36 -05:00
Rom Walton b2c9ab132b VBOX: Make the conditions for one type of error case a bit clearer. 2014-11-23 12:47:33 -05:00
Rom Walton 3941d5153c VBOX: Hookup COM support for both VirtualBox 4.2 and VirtualBox 4.3. It appears to be working. 2014-11-23 12:47:30 -05:00
Rom Walton bf0b56c073 VBOX: Introduce the notion of Virtualbox COM namespaces. We currently support VirtualBox 4.2 and VirtualBox 4.3. 2014-11-23 12:47:05 -05:00