Commit Graph

71 Commits

Author SHA1 Message Date
Christian Beer b31b63e7c1 GAHP Condor: initialize struct members
found by Coverity (CID 34533)
2019-05-28 21:33:18 +02:00
Christian Beer f1fd265fda GAHP Condor: fix sprintf arg mismatch
found by Coverity (CID 165280)
2019-05-28 20:25:49 +02:00
Tim Theisen 0ca1dca439 Update GAHP version string
The existing code depended on building within a git repository.  It
included the GIT_REVISION in the startup message.  Unfortunately,
if you built from a downloaded tarball, the build fails. I thought
that the version of BOINC that the GAHP was compiled against would
be useful information as it is logged.  The SVN_VERSION is still
available by using the --version command line option.  Because of
the small change in behavior, I also bumped the version number of
the GAHP to 1.0.2.
2018-10-03 19:37:10 -05:00
Tim Theisen 4e2f6c66af HTCondor boinc_gahp should compile with -O2 2018-10-02 10:31:05 -05:00
Tim Theisen f65d656f8b Update HTCondor sample code
In our BOINC adapter, we made a change so that the unzip command
does not produce any output and will not stop to ask questions.
This is appropriate for the HTCondor batch system. We have been using
this change since April 18, 2014.
2018-08-07 16:37:56 -05:00
Laurence Field 82880c90aa Added support for job params and app version 2018-05-14 11:58:02 +02:00
Christian Beer 5900360a1f Build: fix distclean target 2017-10-26 15:13:48 +02:00
David Anderson acc1662563 Merge pull request #1827 from BOINC/boinc_gahp_protocol_spec
Remote job submission: first draft of protocol spec file for BOINC-GAHP
2017-09-21 11:18:05 -07:00
Bernd Machenschalk 563af50792 BOINC GAHP: add git SHA1 to version message
- also define BOINC_GAHP_VERSION to conform to GAHP spec (major.minor.subminor)
2017-08-15 09:10:48 +02:00
David Anderson b3d8a0c6e9 Merge pull request #1604 from bema-ligo/boinc_gahp_svn_version
BOINC GAHP: print SVN_VERSION with --version CLA
2017-08-14 13:52:06 -07:00
nikolasgianna 9604aef06c Fix inconsistency between uploaded files and queried ones in boinc_gahp 2017-04-03 14:39:28 +02:00
Christian Beer a00bafea21 Remote job submission: first draft of protocol spec file for BOINC-GAHP
Based on http://research.cs.wisc.edu/htcondor/gahp/gce_gahp_protocol.txt version 0.1, http://boinc.berkeley.edu/trac/wiki/CondorBoinc version 27 and f640f89bb2/samples/condor/boinc_gahp.cpp
2017-03-24 12:19:22 +01:00
Christian Beer 9b74b54f76 Merge pull request #1642 from lfield/gahp-fast-looping-fix
Fixing Gridmanager fast looping issue
2016-09-09 13:05:30 +02:00
Laurence Field 0e4f30d9f1 Fixing Gridmanager fast lopping issue 2016-09-07 11:13:44 +02:00
David Anderson 1d82913b80 Scheduler: fix bug in parsing project prefs. 2016-08-20 15:01:44 -07:00
Bernd Machenschalk cf5ace1a71 BOINC GAHP: print SVN_VERSION with --version CLA 2016-08-04 07:33:08 +02:00
David Anderson d94fe5bcde Merge pull request #1592 from bema-ligo/boinc_gahp_fixes
Boinc gahp fixes
2016-07-31 11:42:28 -07:00
David Anderson 89dc25bc6c Condor interface: compile fix 2016-07-27 23:18:30 -07:00
David Anderson b6c0d75a8c remote job submission: fix bugs, improve error reporting 2016-07-27 01:07:07 -07:00
Bernd Machenschalk 9c15fd2183 BOINC GAHP: assign output files by order, if not found by matching name 2016-07-27 08:41:54 +02:00
Bernd Machenschalk b4a0807c40 BOINC GAHP: append to an existing stderr file instead of overwriting it 2016-07-27 08:41:40 +02:00
Bernd Machenschalk f88c65125b BOINC GAHP: escape paths for system("mv"), in case these contain blanks 2016-07-27 08:41:29 +02:00
David Anderson a259991c7a Fix bugs in content-based file management system
- stray return in compute_boinc_name()
- BoincJobFile::delete() was wrong
- error-check DB record deletions
2016-07-24 22:55:33 -07:00
David Anderson f5c64abac0 Condor GAHP: add extensions to input file names
The content-based file management system used by Condor GAHP
used a file's MD5 hash as its physical name.
This caused problems for Einstein@home because their app
expected filenames with particular extensions.
So I:

- changed the docs and param names of the C++ interface
  to the file management system (query_files() and upload_files())
  to clarify that the physical file names can include additional text
  besides the MD5 hash.
- changed the BOINC GAHP to look for filename extensions,
  and append these to the physical filenames
2016-07-22 16:10:23 -07:00
David Anderson cd87e03c5e remote job submission, C++ interface: support remote input files
This is a first step toward letting Condor job submissions
have remote input files.
Todo: change the GAHP protocol to specify this.
2016-07-22 13:51:04 -07:00
Christian Beer 52cc2b0317 Condor: prevent resource leak
fixes CID 34514 found by Coverity
2015-11-10 17:05:09 +01:00
David Anderson d2c91e16dd client, condor, remote submit: fix a few Coverity warnings 2015-10-14 10:29:15 -07:00
Julien Nabet d75222ebf3 cppcheck: Prefer prefix ++/-- operators for non-primitive types 2015-01-14 21:18:29 +01:00
David Anderson 5bcdacfa64 Condor interface: race condition fix, from Jamie 2014-04-14 13:29:04 -07:00
David Anderson 12b4f43793 Condor interface: when unzipping output file, use job-specific name for temp file to avoid conflict between jobs 2014-03-13 13:07:16 -07:00
David Anderson 01b78c714a Remote job submission: allow efficient batch query
The batch query call used by Condor (query_batch_set(), in the C++ API)
returned info about all the jobs in the set of batches,
even those that hadn't changed.
This is potentially inefficient - a query might return info
about 10,000 jobs, only a few (or none) of which have changed state
since the last call.

Solution: add a "min_mod_time" parameter to the call.
Only jobs that have changed state since that time are reported.
Also, add a "server_time" field to the return,
giving the current time on the server
(in case there's clock skew between client and server)

Also, fix some text scrambling introduced in previous checkin;
there must have been a gremlin in my vim.
2014-01-16 10:24:10 -08:00
David Anderson 438cd78b13 Remote job submission: add C++ APIs for query_batches() and query_batch()
- Add program (tools/remote_submit_test.cpp) for testing C++ API for remote job submission.
- Rename Condor-specific API to query_batch_set().
2013-10-22 15:27:34 -07:00
David Anderson 03cc6849c7 remote job submission: add C++ interface to estimate_batch function 2013-10-21 23:40:30 -07:00
David Anderson 8e8adf46b9 Condor interface: bug fixes. 2013-10-17 22:38:22 -07:00
David Anderson 9d07555ce3 Condor: bug fix to BOINC GAHP, from Jaime 2013-10-09 12:43:40 -07:00
David Anderson 7336bfd9ba Remote job submission, C++ API: simplify 2013-10-08 17:36:45 -07:00
David Anderson 3e21e8b7c4 Condor: debug set_expire_time RPC 2013-09-17 23:14:57 -07:00
David Anderson 2a2c9c4ad8 remote job submission: add notion of "expire time" for batches (for Condor)
- Batches now have optional "expire time".
  If this time passes and the batch is not retired, abort and retire it.
- Add script "expire_batches" which enforces the above.
  Run it as a periodic task.
- Add a web RPC for setting the expire time of a batch
  (it can be changed multiple times)
- Add a C++ interface for this RPC
- Add a BOINC_SET_LEASE command to the BOINC GAHP
  ("lease" is Condor term for expire time)
2013-09-17 13:35:55 -07:00
David Anderson 29c41fd980 Bug fixes for job file management and BOINC GAHP, from Jaime Frey 2013-09-09 16:18:43 -07:00
David Anderson 65fb860317 Condor interface: increase thread stack size 2013-08-30 08:44:33 -07:00
David Anderson 98123560e2 Condor: add variant of uppercase that processes multiple files 2013-08-27 21:24:01 -07:00
David Anderson 1c31f6feaa Condor: fix bug when 2 input files have same contents; fix error messages 2013-08-09 16:06:36 -07:00
David Anderson 74a8a8cad7 Condor: use flockfile() instead of pthread mutex 2013-08-09 14:55:41 -07:00
David Anderson 37e822fe3a Condor: implement asynchronous mode in BOINC GAHP; from Jaime 2013-08-09 13:41:58 -07:00
David Anderson 53f97f9cf1 Condor: fix memory-allocation bugs, from Jaime 2013-08-09 13:33:03 -07:00
David Anderson 213bb934a7 Condor interface changes
BOINC_QUERY_BATCHES now prints, for each queried batch,
    a count of jobs followed by the jobs
BOINC_ABORT_JOBS takes a list of jobs, which may belong to different batches.
    The handler for this looks up the batches and makes sure
    the jobs belong to the user.
2013-05-30 23:38:33 -07:00
David Anderson ff261cb6df Condor interface: bug fixes; add request_gen script; add retire_batch command 2013-05-30 09:44:58 -07:00
David Anderson 8009a8cecb Condor interface: various fixes, mostly from Jaime Frey
- XML parser: for parse_string(), malloc the 256KB buffer instead of
    allocating it on the stack; the latter crashes threads with 32KB stacks.
    However, do the malloc() only if we've actually seen the start tag
    (this required a bit of code shuffle).
- BOINC GAHP: escape spaces in error msgs
2013-05-27 11:45:10 -07:00
David Anderson ff1311bf11 BOINC/Condor interface: tweaks from Jaime Frey 2013-05-21 20:35:14 -07:00
David Anderson 1d63b6d8cc Condor: tweak 2013-05-15 16:50:27 -07:00