web: use the SHOW_USER_PAGE constant instead of 'show_user.php'

html/inc/user.inc

@@ -94,7 +94,12 @@ function show_project($project) {
     if ($project->url == "http://www.worldcommunitygrid.org/") {
         $x = $project->name;
     } else {
-        $x = "<a href=\"$project->url"."show_user.php?userid=$project->id\">$project->name</a>";
+        $x = sprintf(
+            '<a href="%sshow_user.php?userid=%d">%s</a>',
+            $project->url,
+            $project->id,
+            $project->name
+        );
     }
     echo "<tr>
         <td>$x</td>

html/inc/util.inc

@@ -99,7 +99,7 @@ if (!defined('HOME_PAGE')) {
     define('HOME_PAGE', 'home.php');
 }
 
-// the page showing another user.
+// the page showing another user ('userid' arg).
 // Link to here wherever we show a user name.
 //
 if (!defined('SHOW_USER_PAGE')) {

html/user/show_coproc.php

@@ -75,7 +75,10 @@ function show_row($x, $y, $mode) {
         break;
     case 'user':
         $user = BoincUser::lookup_id($x);
-        echo "<a href=show_user.php?userid=$x>$user->name</a>";
+        echo sprintf(
+            '<a href=%s?userid=%d>%s</a>',
+            SHOW_USER_PAGE, $x, $user->name
+        );
         break;
     case 'team':
         $team = BoincTeam::lookup_id($x);

html/user/view_profile.php

@@ -62,8 +62,11 @@ show_profile($user, $logged_in_user);
 end_table();
 echo "</td><td valign=\"top\">";
 start_table("table-striped");
-row2(tra("Account data"),
-    "<a href=\"show_user.php?userid=".$userid."\">".tra("View")."</a>"
+row2(tra("User info"),
+    sprintf(
+        '<a href="%s?userid=%d">%s</a>',
+        SHOW_USER_PAGE, $userid, tra("View")
+    )
 );
 
 community_links($community_links_object, $logged_in_user);