Rooba
/
boinc
mirror of https://github.com/BOINC/boinc.git
1
0
Fork 0
Code Issues 1 Packages Projects Releases Wiki Activity

replace sprintf->snprintf, strcmp->strncmp where possible

This commit is contained in:
Svyatoslav Krasnov 2022-07-12 11:48:37 +00:00
parent ba2754d36b
commit f0f023a695
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sched/sched_util_basic.cpp
View File

@ -192,7 +192,7 @@ int check_download_file(const char* file_path, const char* dl_hier_path) {
return -2; return -2;
} }
sprintf(md5_file_path, "%s.md5", dl_hier_path); snprintf(md5_file_path, MAXPATHLEN, "%s.md5", dl_hier_path);
if (boinc_file_exists(md5_file_path)) { if (boinc_file_exists(md5_file_path)) {
retval = read_file_string(md5_file_path, file_content); retval = read_file_string(md5_file_path, file_content);
if (retval) { if (retval) {
@ -211,7 +211,7 @@ int check_download_file(const char* file_path, const char* dl_hier_path) {
if (retval) { if (retval) {
return -2; return -2;
} }
int hashes_equal = !strcmp(md5_hash_src, md5_hash_dst); int hashes_equal = !strncmp(md5_hash_src, md5_hash_dst, MD5_LEN);
if (md5_file_exists && hashes_equal) { if (md5_file_exists && hashes_equal) {
// the right file with correct .md5 is there // the right file with correct .md5 is there
return 0; return 0;

8
tools/stage_file_native.cpp
View File

@ -40,7 +40,7 @@ static int create_md5_file(const char* file_path, const char* md5_file_path, boo
return retval; return retval;
} }
sprintf(path, "%s.md5", md5_file_path); snprintf(path, MAXPATHLEN, "%s.md5", md5_file_path);
md5_filep = boinc_fopen(path, "w"); md5_filep = boinc_fopen(path, "w");
if (!md5_filep) { if (!md5_filep) {
return ERR_FOPEN; return ERR_FOPEN;
@ -134,7 +134,7 @@ int stage_file(
std::stringstream file_buf; std::stringstream file_buf;
file_buf << file.rdbuf(); file_buf << file.rdbuf();
sprintf(gz_path, "%s.gz", dl_hier_path); snprintf(gz_path, MAXPATHLEN, "%s.gz", dl_hier_path);
gzFile gz = gzopen(gz_path, "w"); gzFile gz = gzopen(gz_path, "w");
if (!gz) { if (!gz) {
fprintf(stderr, "failed to open gz: %s\n", strerror(errno)); fprintf(stderr, "failed to open gz: %s\n", strerror(errno));
@ -225,13 +225,13 @@ int main(int argc, char** argv) {
usage(1); usage(1);
} }
} }
sprintf(path, "%s", argv[argc - 1]); snprintf(path, MAXPATHLEN, "%s", argv[argc - 1]);
if (is_dir(path)) { if (is_dir(path)) {
std::string file_name; std::string file_name;
DirScanner dir(path); DirScanner dir(path);
while (dir.scan(file_name)) { while (dir.scan(file_name)) {
sprintf(file_path, "%s/%s", path, file_name.c_str()); snprintf(file_path, MAXPATHLEN, "%s/%s", path, file_name.c_str());
if (!is_file(file_path)) { if (!is_file(file_path)) {
continue; continue;
} }