diff --git a/checkin_notes b/checkin_notes index 18add1475b..491e695614 100644 --- a/checkin_notes +++ b/checkin_notes @@ -4914,3 +4914,12 @@ Charlie 30 Jun 2010 clientgui/ MainDocument.cpp, .h + +Charlie 30 Jun 2010 + - MGR: after GUI RPC sets NOTICES::complete, only NoticeListCtrl clears it. + - MGR: fix compile warning. + + clientgui/ + NoticeListCtrl.cpp + lib/ + gui_rpc_client_ops.cpp diff --git a/clientgui/NoticeListCtrl.cpp b/clientgui/NoticeListCtrl.cpp index d214ab2277..c3941dbebd 100644 --- a/clientgui/NoticeListCtrl.cpp +++ b/clientgui/NoticeListCtrl.cpp @@ -561,10 +561,11 @@ bool CNoticeListCtrl::UpdateUI() if (pDoc->GetNoticeCount() < 0) return true; if ( - (GetItemCount() != pDoc->GetNoticeCount()) || + ((int)GetItemCount() != pDoc->GetNoticeCount()) || pDoc->notices.complete ) { SetItemCount(pDoc->GetNoticeCount()); + pDoc->notices.complete = false; } return true; } diff --git a/lib/gui_rpc_client_ops.cpp b/lib/gui_rpc_client_ops.cpp index 57436a7a9a..248a61940e 100644 --- a/lib/gui_rpc_client_ops.cpp +++ b/lib/gui_rpc_client_ops.cpp @@ -2353,8 +2353,6 @@ static int parse_notices(MIOFILE& fin, NOTICES& notices) { bool is_tag; int retval; - notices.complete = false; - while (!xp.get(tag, sizeof(tag), is_tag)) { if (!is_tag) continue; if (!strcmp(tag, "notice")) {