diff --git a/checkin_notes b/checkin_notes index 5d8fc5b2cd..9e08c00bed 100644 --- a/checkin_notes +++ b/checkin_notes @@ -5406,3 +5406,22 @@ David 2 July 2008 tools/ make_project + +David 2 July 2008 + - client and server: the client includes global_prefs.xml + in scheduler request messages, without checking its contents. + One user had apparently edited global_prefs.xml with an XML editor; + it had an ")) return "no start tag"; while (fgets(buf, sizeof(buf), fin)) { + // If a line is too long, ignore it. + // This can happen e.g. if the client has bad global_prefs.xml + // This won't be necessary if we rewrite this using XML_PARSER + // + if (!strchr(buf, '\n')) { + while (fgets(buf, sizeof(buf), fin)) { + if (strchr(buf, '\n')) break; + } + continue; + } + if (match_tag(buf, "")) return NULL; if (parse_str(buf, "", authenticator, sizeof(authenticator))) { remove_quotes(authenticator); @@ -340,6 +351,9 @@ const char* SCHEDULER_REQUEST::parse(FILE* fin) { if (match_tag(buf, "")) continue; if (match_tag(buf, "")) continue; if (match_tag(buf, "")) continue; + if (match_tag(buf, "