Rooba
/
boinc
mirror of https://github.com/BOINC/boinc.git
1
0
Fork 0
Code Issues 1 Packages Projects Releases Wiki Activity

MGR: Improvements to comments

This commit is contained in:
Charlie Fenton 2014-02-25 07:48:30 -08:00
parent 082aff7f16
commit b7b9e0acd3
5 changed files with 25 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
clientgui/AdvancedFrame.cpp
View File

@ -1014,10 +1014,9 @@ void CAdvancedFrame::SaveWindowDimensions() {
#ifdef __WXMAC__
// We don't call Hide() or Show(false) for the main frame
// under wxCocoa 2.9.5 because it bounces the Dock icon
// (as in notification.) We work around this by moving
// the main window/frame off screen when displaying the
// CDlgAbout modal dialog while the main window is hidden
// by CTaskBarIcon::OnAbout().
// (as in notification) when we click on our menu bar icon.
// We work around this by moving the main window/frame off
// screen when needed.
pos = GetOnScreenFramePosition();
#endif

6
clientgui/BOINCBaseFrame.cpp
View File

@ -319,6 +319,7 @@ void CBOINCBaseFrame::OnClose(wxCloseEvent& event) {
#elif defined(__WXMAC__)
// Don't call Hide() or Show(false) under wxCocoa 2.9.5
// because it bounces the Dock icon (as in notification)
// when we click on our menu bar icon.
wxGetApp().ShowApplication(false);
#else
Hide();
@ -896,8 +897,9 @@ bool CBOINCBaseFrame::Show(bool bShow) {
// We don't call Hide() or Show(false) for the main frame
// under wxCocoa 2.9.5 because it bounces the Dock icon
// (as in notification.) We work around this by moving
// the main window/frame off screen when needed.
// (as in notification) when we click on our menu bar icon.
// We work around this by moving the main window/frame off
// screen when needed.
// The position will be restored in one of these methods:
// CBOINCGUIApp::OnActivateApp(), CSimpleFrame::SaveState()
// or CAdvancedFrame::SaveWindowDimensions().

14
clientgui/BOINCGUIApp.cpp
View File

@ -470,8 +470,9 @@ bool CBOINCGUIApp::OnInit() {
#ifdef __WXMAC__
// We don't call Hide() or Show(false) for the main frame
// under wxCocoa 2.9.5 because it bounces the Dock icon
// (as in notification.) We work around this by moving
// the main window/frame off screen here.
// (as in notification) when we click on our menu bar icon.
// We work around this by moving the main window/frame off
// screen here.
// The position will be restored in one of these methods:
// CBOINCGUIApp::OnActivateApp(), CSimpleFrame::SaveState()
// or CAdvancedFrame::SaveWindowDimensions().
@ -479,6 +480,8 @@ bool CBOINCGUIApp::OnInit() {
m_pFrame->MoveFrameOffScreen();
m_pFrame->Show();
}
// Force BOINC Manager to background (needed on OS 10.9)
system("osascript -e 'tell application \"Finder\" to activate'");
#endif
ShowApplication(false);
}
@ -839,10 +842,9 @@ void CBOINCGUIApp::OnActivateApp(wxActivateEvent& event) {
#ifdef __WXMAC__
// We don't call Hide() or Show(false) for the main frame
// under wxCocoa 2.9.5 because it bounces the Dock icon
// (as in notification.) We work around this by moving
// the main window/frame off screen when displaying the
// CDlgAbout modal dialog while the main window is hidden
// by CTaskBarIcon::OnAbout().
// (as in notification) when we click on our menu bar icon.
// We work around this by moving the main window/frame off
// screen when needed.
if (m_pFrame) {
if (event.GetActive()) {
if (!m_bAboutDialogIsOpen) {

7
clientgui/BOINCTaskBar.cpp
View File

@ -259,9 +259,10 @@ void CTaskBarIcon::OnAbout(wxCommandEvent& WXUNUSED(event)) {
// We don't call Hide() or Show(false) for the main frame
// under wxCocoa 2.9.5 because it bounces the Dock icon
// (as in notification.) We work around this by moving
// the main window/frame off screen when displaying the
// CDlgAbout modal dialog while the main window is hidden.
// (as in notification) when we click on our menu bar icon.
// We work around this by moving the main window/frame off
// screen when displaying the CDlgAbout modal dialog while
// the main window is hidden.
// The position will be restored in one of these methods:
// CBOINCGUIApp::OnActivateApp(), CSimpleFrame::SaveState()
// or CAdvancedFrame::SaveWindowDimensions().

10
clientgui/sg_BoincSimpleFrame.cpp
View File

@ -321,10 +321,12 @@ bool CSimpleFrame::SaveState() {
#ifdef __WXMAC__
// We don't call Hide() or Show(false) for the main frame
// under wxCocoa 2.9.5 because it bounces the Dock icon
// (as in notification.) We work around this by moving
// the main window/frame off screen when displaying the
// CDlgAbout modal dialog while the main window is hidden
// by CTaskBarIcon::OnAbout().
// (as in notification) when we click on our menu bar icon.
// We work around this by moving the main window/frame off
// screen when needed.
// The position will be restored in one of these methods:
// CBOINCGUIApp::OnActivateApp(), CSimpleFrame::SaveState()
// or CAdvancedFrame::SaveWindowDimensions().
pos = GetOnScreenFramePosition();
#endif