Rooba
/
boinc
mirror of https://github.com/BOINC/boinc.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

- lib: parse <available_ram> in coproc XML 

- lib: do coproc XML parsing using new XML parser


svn path=/trunk/boinc/; revision=24215
This commit is contained in:
David Anderson 2011-09-15 04:24:40 +00:00
parent 3d9e3097ee
commit a2f6b62d97
5 changed files with 219 additions and 115 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
checkin_notes
View File

@ -6065,3 +6065,11 @@ David 14 Sept 2011
lib/ lib/
coproc.cpp coproc.cpp
David 14 Sept 2011
- lib: parse <available_ram> in coproc XML
- lib: do coproc XML parsing using new XML parser
lib/
parse.cpp,h
coproc.cpp,h

220
lib/coproc.cpp
View File

@ -56,17 +56,15 @@ using std::perror;
#endif #endif
int COPROC_REQ::parse(XML_PARSER& xp) { int COPROC_REQ::parse(XML_PARSER& xp) {
char buf[1024];
strcpy(type, ""); strcpy(type, "");
count = 0; count = 0;
MIOFILE& in = *(xp.f); while (!xp.get_tag()) {
while (in.fgets(buf, sizeof(buf))) { if (xp.match_tag("/coproc")) {
if (match_tag(buf, "</coproc>")) {
if (!strlen(type)) return ERR_XML_PARSE; if (!strlen(type)) return ERR_XML_PARSE;
return 0; return 0;
} }
if (parse_str(buf, "<type>", type, sizeof(type))) continue; if (xp.parse_str("type", type, sizeof(type))) continue;
if (parse_double(buf, "<count>", count)) continue; if (xp.parse_double("count", count)) continue;
} }
return ERR_XML_PARSE; return ERR_XML_PARSE;
} }
@ -167,57 +165,79 @@ int COPROC::parse(XML_PARSER& xp) {
#endif #endif
int COPROC::parse_opencl(XML_PARSER& xp) { int COPROC::parse_opencl(XML_PARSER& xp) {
char buf[1024];
int n; int n;
unsigned long ul;
unsigned long long ull;
MIOFILE& in = *(xp.f); while (!xp.get_tag()) {
while (in.fgets(buf, sizeof(buf))) { if (xp.match_tag("/coproc_opencl")) {
if (match_tag(buf, "</coproc_opencl>")) {
return 0; return 0;
} }
if (parse_str(buf, "<name>", opencl_prop.name, sizeof(opencl_prop.name))) continue; if (xp.parse_str("name", opencl_prop.name, sizeof(opencl_prop.name))) continue;
if (parse_str(buf, "<vendor>", opencl_prop.vendor, sizeof(opencl_prop.vendor))) continue; if (xp.parse_str("vendor", opencl_prop.vendor, sizeof(opencl_prop.vendor))) continue;
if (parse_double(buf, "<peak_flops>", peak_flops)) continue; if (xp.parse_double("peak_flops", peak_flops)) continue;
if (parse_int(buf, "<available>", n)) { if (xp.parse_int("available", n)) {
opencl_prop.available = n; opencl_prop.available = n;
continue; continue;
} }
if (parse_cl_ulong(buf, "<hp_fp_config>", opencl_prop.hp_fp_config)) continue; if (xp.parse_ulonglong("hp_fp_config", ull)) {
if (parse_cl_ulong(buf, "<sp_fp_config>", opencl_prop.sp_fp_config)) continue; opencl_prop.hp_fp_config = ull;
if (parse_cl_ulong(buf, "<dp_fp_config>", opencl_prop.dp_fp_config)) continue; continue;
if (parse_int(buf, "<little_endian>", n)) { }
if (xp.parse_ulonglong("sp_fp_config", ull)) {
opencl_prop.sp_fp_config = ull;
continue;
}
if (xp.parse_ulonglong("dp_fp_config", ull)) {
opencl_prop.dp_fp_config = ull;
continue;
}
if (xp.parse_int("little_endian", n)) {
opencl_prop.little_endian = n; opencl_prop.little_endian = n;
continue; continue;
} }
if (parse_cl_ulong(buf, "<exec_capabilities>", opencl_prop.exec_capab)) continue; if (xp.parse_ulonglong("exec_capabilities", ull)) {
if (parse_str(buf, "<extensions>", opencl_prop.exec_capab = ull;
opencl_prop.extensions,
sizeof(opencl_prop.extensions))) {
continue; continue;
} }
if (parse_cl_ulong(buf, "<global_RAM>", opencl_prop.global_RAM)) continue; if (xp.parse_str("extensions",
if (parse_cl_ulong(buf, "<local_RAM>", opencl_prop.local_RAM)) continue; opencl_prop.extensions,
if (parse_int(buf, "<max_clock_freq>", n)) { sizeof(opencl_prop.extensions)
)) {
continue;
}
if (xp.parse_ulonglong("global_RAM", ull)) {
opencl_prop.global_RAM = ull;
continue;
}
if (xp.parse_ulonglong("local_RAM", ull)) {
opencl_prop.local_RAM = ull;
continue;
}
if (xp.parse_int("max_clock_freq", n)) {
opencl_prop.max_clock_freq = n; opencl_prop.max_clock_freq = n;
continue; continue;
} }
if (parse_int(buf, "<max_cores>", n)) { if (xp.parse_int("max_cores", n)) {
opencl_prop.max_cores = n; opencl_prop.max_cores = n;
continue; continue;
} }
if (parse_str(buf, "<openCL_platform_version>", if (xp.parse_str("openCL_platform_version",
opencl_prop.openCL_platform_version, opencl_prop.openCL_platform_version,
sizeof(opencl_prop.openCL_platform_version))) { sizeof(opencl_prop.openCL_platform_version)
)) {
continue; continue;
} }
if (parse_str(buf, "<openCL_device_version>", if (xp.parse_str("openCL_device_version",
opencl_prop.openCL_device_version, opencl_prop.openCL_device_version,
sizeof(opencl_prop.openCL_device_version))) { sizeof(opencl_prop.openCL_device_version)
)) {
continue; continue;
} }
if (parse_str(buf, "<openCL_driver_version>", if (xp.parse_str("openCL_driver_version",
opencl_prop.openCL_driver_version, opencl_prop.openCL_driver_version,
sizeof(opencl_prop.openCL_driver_version))) { sizeof(opencl_prop.openCL_driver_version)
)) {
continue; continue;
} }
} }
@ -314,13 +334,11 @@ void COPROC_NVIDIA::write_xml(MIOFILE& f, bool include_request) {
" <name>%s</name>\n" " <name>%s</name>\n"
" <available_ram>%f</available_ram>\n" " <available_ram>%f</available_ram>\n"
" <have_cuda>%d</have_cuda>\n" " <have_cuda>%d</have_cuda>\n"
" <have_cal>%d</have_cal>\n"
" <have_opencl>%d</have_opencl>\n", " <have_opencl>%d</have_opencl>\n",
count, count,
prop.name, prop.name,
available_ram, available_ram,
have_cuda ? 1 : 0, have_cuda ? 1 : 0,
have_cal ? 1 : 0,
have_opencl ? 1 : 0 have_opencl ? 1 : 0
); );
if (include_request) { if (include_request) {
@ -405,40 +423,39 @@ void COPROC_NVIDIA::clear() {
} }
int COPROC_NVIDIA::parse(XML_PARSER& xp) { int COPROC_NVIDIA::parse(XML_PARSER& xp) {
char buf[1024], buf2[256]; char buf2[256];
int retval; int retval;
clear(); clear();
MIOFILE& in = *(xp.f); while (!xp.get_tag()) {
while (in.fgets(buf, sizeof(buf))) { if (xp.match_tag("/coproc_cuda")) {
if (strstr(buf, "</coproc_cuda>")) {
if (!peak_flops) { if (!peak_flops) {
set_peak_flops(); set_peak_flops();
} }
return 0; return 0;
} }
if (parse_int(buf, "<count>", count)) continue; if (xp.parse_int("count", count)) continue;
if (parse_double(buf, "<peak_flops>", peak_flops)) continue; if (xp.parse_double("peak_flops", peak_flops)) continue;
if (parse_bool(buf, "have_cuda", have_cuda)) continue; if (xp.parse_bool("have_cuda", have_cuda)) continue;
if (parse_bool(buf, "have_cal", have_cal)) continue; if (xp.parse_bool("have_opencl", have_opencl)) continue;
if (parse_bool(buf, "have_opencl", have_opencl)) continue; if (xp.parse_double("available_ram", available_ram)) continue;
if (parse_double(buf, "<req_secs>", req_secs)) continue; if (xp.parse_double("req_secs", req_secs)) continue;
if (parse_double(buf, "<req_instances>", req_instances)) continue; if (xp.parse_double("req_instances", req_instances)) continue;
if (parse_double(buf, "<estimated_delay>", estimated_delay)) continue; if (xp.parse_double("estimated_delay", estimated_delay)) continue;
if (parse_int(buf, "<cudaVersion>", cuda_version)) continue; if (xp.parse_int("cudaVersion", cuda_version)) continue;
if (parse_int(buf, "<drvVersion>", display_driver_version)) continue; if (xp.parse_int("drvVersion", display_driver_version)) continue;
if (parse_str(buf, "<name>", prop.name, sizeof(prop.name))) continue; if (xp.parse_str("name", prop.name, sizeof(prop.name))) continue;
if (parse_int(buf, "<deviceHandle>", prop.deviceHandle)) continue; if (xp.parse_int("deviceHandle", prop.deviceHandle)) continue;
if (parse_double(buf, "<totalGlobalMem>", prop.dtotalGlobalMem)) { if (xp.parse_double("totalGlobalMem", prop.dtotalGlobalMem)) {
prop.totalGlobalMem = (int)prop.dtotalGlobalMem; prop.totalGlobalMem = (int)prop.dtotalGlobalMem;
continue; continue;
} }
if (parse_int(buf, "<sharedMemPerBlock>", (int&)prop.sharedMemPerBlock)) continue; if (xp.parse_int("sharedMemPerBlock", (int&)prop.sharedMemPerBlock)) continue;
if (parse_int(buf, "<regsPerBlock>", prop.regsPerBlock)) continue; if (xp.parse_int("regsPerBlock", prop.regsPerBlock)) continue;
if (parse_int(buf, "<warpSize>", prop.warpSize)) continue; if (xp.parse_int("warpSize", prop.warpSize)) continue;
if (parse_int(buf, "<memPitch>", (int&)prop.memPitch)) continue; if (xp.parse_int("memPitch", (int&)prop.memPitch)) continue;
if (parse_int(buf, "<maxThreadsPerBlock>", prop.maxThreadsPerBlock)) continue; if (xp.parse_int("maxThreadsPerBlock", prop.maxThreadsPerBlock)) continue;
if (parse_str(buf, "<maxThreadsDim>", buf2, sizeof(buf2))) { if (xp.parse_str("maxThreadsDim", buf2, sizeof(buf2))) {
// can't use sscanf here (FCGI) // can't use sscanf here (FCGI)
// //
prop.maxThreadsDim[0] = atoi(buf2); prop.maxThreadsDim[0] = atoi(buf2);
@ -454,7 +471,7 @@ int COPROC_NVIDIA::parse(XML_PARSER& xp) {
} }
continue; continue;
} }
if (parse_str(buf, "<maxGridSize>", buf2, sizeof(buf2))) { if (xp.parse_str("maxGridSize", buf2, sizeof(buf2))) {
prop.maxGridSize[0] = atoi(buf2); prop.maxGridSize[0] = atoi(buf2);
char* p = strchr(buf2, ' '); char* p = strchr(buf2, ' ');
if (p) { if (p) {
@ -468,14 +485,14 @@ int COPROC_NVIDIA::parse(XML_PARSER& xp) {
} }
continue; continue;
} }
if (parse_int(buf, "<clockRate>", prop.clockRate)) continue; if (xp.parse_int("clockRate", prop.clockRate)) continue;
if (parse_int(buf, "<totalConstMem>", (int&)prop.totalConstMem)) continue; if (xp.parse_int("totalConstMem", (int&)prop.totalConstMem)) continue;
if (parse_int(buf, "<major>", prop.major)) continue; if (xp.parse_int("major", prop.major)) continue;
if (parse_int(buf, "<minor>", prop.minor)) continue; if (xp.parse_int("minor", prop.minor)) continue;
if (parse_int(buf, "<textureAlignment>", (int&)prop.textureAlignment)) continue; if (xp.parse_int("textureAlignment", (int&)prop.textureAlignment)) continue;
if (parse_int(buf, "<deviceOverlap>", prop.deviceOverlap)) continue; if (xp.parse_int("deviceOverlap", prop.deviceOverlap)) continue;
if (parse_int(buf, "<multiProcessorCount>", prop.multiProcessorCount)) continue; if (xp.parse_int("multiProcessorCount", prop.multiProcessorCount)) continue;
if (match_tag(buf, "<coproc_opencl>")) { if (xp.match_tag("coproc_opencl")) {
retval = parse_opencl(xp); retval = parse_opencl(xp);
if (retval) return retval; if (retval) return retval;
continue; continue;
@ -493,13 +510,11 @@ void COPROC_ATI::write_xml(MIOFILE& f, bool include_request) {
" <count>%d</count>\n" " <count>%d</count>\n"
" <name>%s</name>\n" " <name>%s</name>\n"
" <available_ram>%f</available_ram>\n" " <available_ram>%f</available_ram>\n"
" <have_cuda>%d</have_cuda>\n"
" <have_cal>%d</have_cal>\n" " <have_cal>%d</have_cal>\n"
" <have_opencl>%d</have_opencl>\n", " <have_opencl>%d</have_opencl>\n",
count, count,
name, name,
available_ram, available_ram,
have_cuda ? 1 : 0,
have_cal ? 1 : 0, have_cal ? 1 : 0,
have_opencl ? 1 : 0 have_opencl ? 1 : 0
); );
@ -570,15 +585,12 @@ void COPROC_ATI::clear() {
} }
int COPROC_ATI::parse(XML_PARSER& xp) { int COPROC_ATI::parse(XML_PARSER& xp) {
char buf[1024]; int n, retval;
int n;
int retval;
clear(); clear();
MIOFILE& in = *(xp.f); while (!xp.get_tag()) {
while (in.fgets(buf, sizeof(buf))) { if (xp.match_tag("/coproc_ati")) {
if (strstr(buf, "</coproc_ati>")) {
int major, minor, release; int major, minor, release;
sscanf(version, "%d.%d.%d", &major, &minor, &release); sscanf(version, "%d.%d.%d", &major, &minor, &release);
version_num = major*1000000 + minor*1000 + release; version_num = major*1000000 + minor*1000 + release;
@ -588,76 +600,76 @@ int COPROC_ATI::parse(XML_PARSER& xp) {
} }
return 0; return 0;
} }
if (parse_int(buf, "<count>", count)) continue; if (xp.parse_int("count", count)) continue;
if (parse_double(buf, "<peak_flops>", peak_flops)) continue; if (xp.parse_double("peak_flops", peak_flops)) continue;
if (parse_bool(buf, "have_cuda", have_cuda)) continue; if (xp.parse_bool("have_cal", have_cal)) continue;
if (parse_bool(buf, "have_cal", have_cal)) continue; if (xp.parse_bool("have_opencl", have_opencl)) continue;
if (parse_bool(buf, "have_opencl", have_opencl)) continue; if (xp.parse_double("available_ram", available_ram)) continue;
if (parse_double(buf, "<req_secs>", req_secs)) continue; if (xp.parse_double("req_secs", req_secs)) continue;
if (parse_double(buf, "<req_instances>", req_instances)) continue; if (xp.parse_double("req_instances", req_instances)) continue;
if (parse_double(buf, "<estimated_delay>", estimated_delay)) continue; if (xp.parse_double("estimated_delay", estimated_delay)) continue;
if (parse_str(buf, "<name>", name, sizeof(name))) continue; if (xp.parse_str("name", name, sizeof(name))) continue;
if (parse_str(buf, "<CALVersion>", version, sizeof(version))) continue; if (xp.parse_str("CALVersion", version, sizeof(version))) continue;
if (parse_bool(buf, "amdrt_detected", amdrt_detected)) continue; if (xp.parse_bool("amdrt_detected", amdrt_detected)) continue;
if (parse_bool(buf, "atirt_detected", atirt_detected)) continue; if (xp.parse_bool("atirt_detected", atirt_detected)) continue;
if (parse_int(buf, "<target>", n)) { if (xp.parse_int("target", n)) {
attribs.target = (CALtarget)n; attribs.target = (CALtarget)n;
continue; continue;
} }
if (parse_int(buf, "<localRAM>", n)) { if (xp.parse_int("localRAM", n)) {
attribs.localRAM = n; attribs.localRAM = n;
continue; continue;
} }
if (parse_int(buf, "<uncachedRemoteRAM>", n)) { if (xp.parse_int("uncachedRemoteRAM", n)) {
attribs.uncachedRemoteRAM = n; attribs.uncachedRemoteRAM = n;
continue; continue;
} }
if (parse_int(buf, "<cachedRemoteRAM>", n)) { if (xp.parse_int("cachedRemoteRAM", n)) {
attribs.cachedRemoteRAM = n; attribs.cachedRemoteRAM = n;
continue; continue;
} }
if (parse_int(buf, "<engineClock>", n)) { if (xp.parse_int("engineClock", n)) {
attribs.engineClock = n; attribs.engineClock = n;
continue; continue;
} }
if (parse_int(buf, "<memoryClock>", n)) { if (xp.parse_int("memoryClock", n)) {
attribs.memoryClock = n; attribs.memoryClock = n;
continue; continue;
} }
if (parse_int(buf, "<wavefrontSize>", n)) { if (xp.parse_int("wavefrontSize", n)) {
attribs.wavefrontSize = n; attribs.wavefrontSize = n;
continue; continue;
} }
if (parse_int(buf, "<numberOfSIMD>" , n)) { if (xp.parse_int("numberOfSIMD" , n)) {
attribs.numberOfSIMD = n; attribs.numberOfSIMD = n;
continue; continue;
} }
if (parse_int(buf, "<doublePrecision>", n)) { if (xp.parse_int("doublePrecision", n)) {
attribs.doublePrecision = n?CAL_TRUE:CAL_FALSE; attribs.doublePrecision = n?CAL_TRUE:CAL_FALSE;
continue; continue;
} }
if (parse_int(buf, "<pitch_alignment>", n)) { if (xp.parse_int("pitch_alignment", n)) {
attribs.pitch_alignment = n; attribs.pitch_alignment = n;
continue; continue;
} }
if (parse_int(buf, "<surface_alignment>", n)) { if (xp.parse_int("surface_alignment", n)) {
attribs.surface_alignment = n; attribs.surface_alignment = n;
continue; continue;
} }
if (parse_int(buf, "<maxResource1DWidth>", n)) { if (xp.parse_int("maxResource1DWidth", n)) {
info.maxResource1DWidth = n; info.maxResource1DWidth = n;
continue; continue;
} }
if (parse_int(buf, "<maxResource2DWidth>", n)) { if (xp.parse_int("maxResource2DWidth", n)) {
info.maxResource2DWidth = n; info.maxResource2DWidth = n;
continue; continue;
} }
if (parse_int(buf, "<maxResource2DHeight>", n)) { if (xp.parse_int("maxResource2DHeight", n)) {
info.maxResource2DHeight = n; info.maxResource2DHeight = n;
continue; continue;
} }
if (match_tag(buf, "<coproc_opencl>")) { if (xp.match_tag("coproc_opencl")) {
retval = parse_opencl(xp); retval = parse_opencl(xp);
if (retval) return retval; if (retval) return retval;
continue; continue;

3
lib/coproc.h
View File

@ -134,6 +134,7 @@ struct COPROC {
bool have_cuda; // True if this GPU supports CUDA on this computer bool have_cuda; // True if this GPU supports CUDA on this computer
bool have_cal; // True if this GPU supports CAL on this computer bool have_cal; // True if this GPU supports CAL on this computer
bool have_opencl; // True if this GPU supports openCL on this computer bool have_opencl; // True if this GPU supports openCL on this computer
double available_ram;
// the following are used in both client and server for work-fetch info // the following are used in both client and server for work-fetch info
// //
@ -160,7 +161,6 @@ struct COPROC {
int opencl_device_count; int opencl_device_count;
bool running_graphics_app[MAX_COPROC_INSTANCES]; bool running_graphics_app[MAX_COPROC_INSTANCES];
// is this GPU running a graphics app (NVIDIA only) // is this GPU running a graphics app (NVIDIA only)
double available_ram;
double available_ram_temp[MAX_COPROC_INSTANCES]; double available_ram_temp[MAX_COPROC_INSTANCES];
// used during job scheduling // used during job scheduling
@ -185,6 +185,7 @@ struct COPROC {
have_cuda = false; have_cuda = false;
have_cal = false; have_cal = false;
have_opencl = false; have_opencl = false;
available_ram = -1;
req_secs = 0; req_secs = 0;
req_instances = 0; req_instances = 0;
opencl_device_count = 0; opencl_device_count = 0;

74
lib/parse.cpp
View File

@ -752,7 +752,7 @@ bool XML_PARSER::parse_int(const char* start_tag, int& i) {
} }
errno = 0; errno = 0;
int val = strtol(buf, &end, 0); int val = strtol(buf, &end, 0);
if (errno == ERANGE) return false; if (errno) return false;
if (end != buf+strlen(buf)) return false; if (end != buf+strlen(buf)) return false;
eof = get(tag, sizeof(tag), is_tag); eof = get(tag, sizeof(tag), is_tag);
@ -785,7 +785,79 @@ bool XML_PARSER::parse_double(const char* start_tag, double& x) {
return false; return false;
} }
} }
errno = 0;
double val = strtod(buf, &end); double val = strtod(buf, &end);
if (errno) return false;
if (end != buf+strlen(buf)) return false;
eof = get(tag, sizeof(tag), is_tag);
if (eof) return false;
if (!is_tag) return false;
if (strcmp(tag, end_tag)) return false;
x = val;
return true;
}
// Same, for unsigned long
//
bool XML_PARSER::parse_ulong(const char* start_tag, unsigned long& x) {
char buf[256], *end;
bool eof;
char end_tag[256], tag[256];
if (strcmp(parsed_tag, start_tag)) return false;
end_tag[0] = '/';
strcpy(end_tag+1, start_tag);
eof = get(buf, sizeof(buf), is_tag);
if (eof) return false;
if (is_tag) {
if (!strcmp(buf, end_tag)) {
x = 0; // treat <foo></foo> as <foo>0</foo>
return true;
} else {
return false;
}
}
errno = 0;
unsigned long val = strtoul(buf, &end, 0);
if (errno) return false;
if (end != buf+strlen(buf)) return false;
eof = get(tag, sizeof(tag), is_tag);
if (eof) return false;
if (!is_tag) return false;
if (strcmp(tag, end_tag)) return false;
x = val;
return true;
}
// Same, for unsigned long long
//
bool XML_PARSER::parse_ulonglong(const char* start_tag, unsigned long long& x) {
char buf[256], *end;
bool eof;
char end_tag[256], tag[256];
if (strcmp(parsed_tag, start_tag)) return false;
end_tag[0] = '/';
strcpy(end_tag+1, start_tag);
eof = get(buf, sizeof(buf), is_tag);
if (eof) return false;
if (is_tag) {
if (!strcmp(buf, end_tag)) {
x = 0; // treat <foo></foo> as <foo>0</foo>
return true;
} else {
return false;
}
}
errno = 0;
unsigned long long val = boinc_strtoull(buf, &end, 0);
if (errno) return false;
if (end != buf+strlen(buf)) return false; if (end != buf+strlen(buf)) return false;
eof = get(tag, sizeof(tag), is_tag); eof = get(tag, sizeof(tag), is_tag);

29
lib/parse.h
View File

@ -51,6 +51,8 @@ public:
bool parse_string(const char*, std::string&); bool parse_string(const char*, std::string&);
bool parse_int(const char*, int&); bool parse_int(const char*, int&);
bool parse_double(const char*, double&); bool parse_double(const char*, double&);
bool parse_ulong(const char*, unsigned long&);
bool parse_ulonglong(const char*, unsigned long long&);
bool parse_bool(const char*, bool&); bool parse_bool(const char*, bool&);
int element_contents(const char*, char*, int); int element_contents(const char*, char*, int);
int copy_element(std::string&); int copy_element(std::string&);
@ -109,8 +111,9 @@ inline unsigned long long boinc_strtoull(const char *s, char **, int) {
inline bool parse_int(const char* buf, const char* tag, int& x) { inline bool parse_int(const char* buf, const char* tag, int& x) {
const char* p = strstr(buf, tag); const char* p = strstr(buf, tag);
if (!p) return false; if (!p) return false;
errno = 0;
int y = strtol(p+strlen(tag), 0, 0); // this parses 0xabcd correctly int y = strtol(p+strlen(tag), 0, 0); // this parses 0xabcd correctly
if (errno == ERANGE) return false; if (errno) return false;
x = y; x = y;
return true; return true;
} }
@ -121,7 +124,9 @@ inline bool parse_double(const char* buf, const char* tag, double& x) {
double y; double y;
const char* p = strstr(buf, tag); const char* p = strstr(buf, tag);
if (!p) return false; if (!p) return false;
y = atof(p+strlen(tag)); errno = 0;
y = strtod(p+strlen(tag), NULL);
if (errno) return false;
if (!boinc_is_finite(y)) { if (!boinc_is_finite(y)) {
return false; return false;
} }
@ -129,28 +134,34 @@ inline bool parse_double(const char* buf, const char* tag, double& x) {
return true; return true;
} }
#if 0
// Same, for unsigned long // Same, for unsigned long
// //
inline bool parse_ulong(const char* buf, const char* tag, unsigned long& x) { inline bool parse_ulong(const char* buf, const char* tag, unsigned long& x) {
const char* p = strstr(buf, tag); const char* p = strstr(buf, tag);
if (!p) return false; if (!p) return false;
unsigned long y = strtoul(p+strlen(tag), NULL, 0); // this parses 0xabcd correctly errno = 0;
if (errno == ERANGE) return false; unsigned long y = strtoul(p+strlen(tag), NULL, 0);
if (errno) return false;
x = y; x = y;
return true; return true;
} }
// Same, for unsigned long long // Same, for unsigned long long
// //
inline bool parse_cl_ulong(const char* buf, const char* tag, cl_ulong& x) { inline bool parse_ulonglong(
const char* buf, const char* tag, unsigned long long& x
) {
const char* p = strstr(buf, tag); const char* p = strstr(buf, tag);
if (!p) return false; if (!p) return false;
unsigned long long y = boinc_strtoull(p+strlen(tag), NULL, 0); // this parses 0xabcd correctly errno = 0;
if (errno == ERANGE) return false; unsigned long long y = boinc_strtoull(p+strlen(tag), NULL, 0);
if (errno) return false;
x = y; x = y;
return true; return true;
} }
#endif
extern bool parse(char* , char* ); extern bool parse(char* , char* );
extern bool parse_str(const char*, const char*, char*, int); extern bool parse_str(const char*, const char*, char*, int);
extern bool parse_str(const char* buf, const char* tag, std::string& dest); extern bool parse_str(const char* buf, const char* tag, std::string& dest);