From 9e072c9a6cfc9c9359c8dd3132dcb8307eb3abfb Mon Sep 17 00:00:00 2001
From: Juha Sointusalo <juha.sointusalo@gmail.com>
Date: Sat, 28 Oct 2017 00:44:26 +0300
Subject: [PATCH] mgr: adjust Event Log stripe color

On Windows, wxListCtrl has a bug that makes it draw selected unfocused rows with colors used for selected focused rows when the row background color is wxSYS_COLOUR_BTNFACE.

With default color schemes, on Windows XP the list is drawn correctly, but on Windows 10 the (240,240,240) used in stripe color is coincidentally the same as wxSYS_COLOUR_BTNFACE and selected rows are drawn with wrong colors.

Fix this by using the same stripe color that wxWidgets would use by default and that is used in Projects, Tasks and Transfers lists. Future proof the code by including a workaround just in case Windows changes color scheme again. If such color scheme change occurs then the same workaround needs to be added to Projects, Tasks and Transfers lists.

Fixes #1083.
---
 clientgui/DlgEventLog.cpp | 38 ++++++++++++++++++++++++++++++++++++--
 1 file changed, 36 insertions(+), 2 deletions(-)

diff --git a/clientgui/DlgEventLog.cpp b/clientgui/DlgEventLog.cpp
index b7985f54af..bd2878f0fe 100644
--- a/clientgui/DlgEventLog.cpp
+++ b/clientgui/DlgEventLog.cpp
@@ -248,13 +248,47 @@ bool CDlgEventLog::Create( wxWindow* parent, wxWindowID id, const wxString& capt
         wxSystemSettings::GetColour(wxSYS_COLOUR_WINDOW),
         wxNullFont
     );
+
 #if EVENT_LOG_STRIPES
+    m_pList->EnableAlternateRowColours();
+    wxColour stripe_color;
+
+#if wxCHECK_VERSION(3, 1, 0)
+    stripe_color = m_pList->GetAlternateRowColour();
+    if (!stripe_color.IsOk())
+#endif
+    {
+        // copied from wxListCtrlBase::EnableAlternateRowColours(bool)
+
+        // Determine the alternate rows colour automatically from the
+        // background colour.
+        const wxColour bgColour = m_pList->GetBackgroundColour();
+
+        // Depending on the background, alternate row color
+        // will be 3% more dark or 50% brighter.
+        int alpha = bgColour.GetRGB() > 0x808080 ? 97 : 150;
+        stripe_color = bgColour.ChangeLightness(alpha);
+    }
+
+#ifdef __WXMSW__
+    // work around a bug in wxWidgets 3.1 and earlier
+    // if row background color is wxSYS_COLOR_BTNFACE selected unfocused row is drawn with wrong colors
+    if (stripe_color == wxSystemSettings::GetColour(wxSYS_COLOUR_BTNFACE)) {
+        // adjust the color just enough to make it different
+        stripe_color.SetRGB(stripe_color.GetRGB() + 1);
+    }
+#endif
+
     m_pMessageInfoGrayAttr = new wxListItemAttr(
         wxSystemSettings::GetColour(wxSYS_COLOUR_WINDOWTEXT),
-        wxColour(240, 240, 240),
+        stripe_color,
+        wxNullFont
+    );
+    m_pMessageErrorGrayAttr = new wxListItemAttr(
+        *wxRED,
+        stripe_color,
         wxNullFont
     );
-    m_pMessageErrorGrayAttr = new wxListItemAttr(*wxRED, wxColour(240, 240, 240), wxNullFont);
 #else
     m_pMessageInfoGrayAttr = new wxListItemAttr(*m_pMessageInfoAttr);
     m_pMessageErrorGrayAttr = new wxListItemAttr(*m_pMessageErrorAttr);