Add "ToDo" comments at code which works around wxWidgets 2.9.4 bugs reminding us to remove the extra code when bugs are fixed in wxWidgets

This commit is contained in:
Charlie Fenton 2012-10-28 01:24:40 -07:00 committed by Oliver Bock
parent e23c329263
commit 92e2ba46ad
4 changed files with 11 additions and 1 deletions

View File

@ -6252,6 +6252,10 @@ Charlie 26 Oct 2012
Charlie 28 Oct 2012
- Mac: Work around apparent refresh bug in wxCarbon 2.9.4 wxGenericListCtrl.
- Add "ToDo" comments at code which works around wxWidgets 2.9.4 bugs
reminding us to remove the extra code when bugs are fixed in wxWidgets.
clientgui/
AdvancedFrame.cpp,.h
DlgEventLog.cpp
sg_BoincSimpleFrame.cpp

View File

@ -195,6 +195,8 @@ BEGIN_EVENT_TABLE (CAdvancedFrame, CBOINCBaseFrame)
EVT_SIZE(CAdvancedFrame::OnSize)
EVT_MOVE(CAdvancedFrame::OnMove)
#ifdef __WXMAC__
// Work around an apparent bug in wxCarbon 2.9.4
// TODO: remove this when the wxCarbon bug is fixed
EVT_SHOW( CAdvancedFrame::OnShow )
#endif
END_EVENT_TABLE ()
@ -1040,6 +1042,7 @@ void CAdvancedFrame::OnMove(wxMoveEvent& event) {
#ifdef __WXMAC__
// Work around an apparent bug in wxCarbon 2.9.4
// TODO: remove this when the wxCarbon bug is fixed
void CAdvancedFrame::OnShow(wxShowEvent& event) {
wxLogTrace(wxT("Function Start/End"), wxT("CAdvancedFrame::OnShow - Function Begin"));

View File

@ -132,6 +132,8 @@ private:
void OnSize(wxSizeEvent& event);
void OnMove(wxMoveEvent& event);
#ifdef __WXMAC__
// Work around an apparent bug in wxCarbon 2.9.4
// TODO: remove this when the wxCarbon bug is fixed
void OnShow(wxShowEvent& event);
#endif

View File

@ -814,7 +814,8 @@ void CSimpleGUIPanel::SetBackgroundBitmap() {
dc.SetBackground(bgBrush);
dc.Clear();
#ifdef __WXMAC__
// Work around an apparent bug in wxMemoryDC::Clear()
// Work around an apparent bug in wxMemoryDC::Clear() in wxCarbon 2.9.4
// TODO: remove this when the wxCarbon bug is fixed
dc.SetBrush(bgBrush);
wxPen bgPen(bgColor);
dc.SetPen(bgPen);