From 881e1b0bc2384f74fe6f90170170f54c8dca13db Mon Sep 17 00:00:00 2001 From: Juha Sointusalo Date: Tue, 20 Nov 2018 23:50:39 +0200 Subject: [PATCH] mgr: check if RPC succeeded The RPC may fail. If the return value is not checked the Manager will continue as if the client accepted the command and created the account successfully. In reality the client returns some garbage account details. --- clientgui/ProjectProcessingPage.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/clientgui/ProjectProcessingPage.cpp b/clientgui/ProjectProcessingPage.cpp index d7a95de72b..e8bf9810cb 100644 --- a/clientgui/ProjectProcessingPage.cpp +++ b/clientgui/ProjectProcessingPage.cpp @@ -436,7 +436,8 @@ void CProjectProcessingPage::OnStateChange( CProjectProcessingPageEvent& WXUNUSE !CHECK_CLOSINGINPROGRESS() ) { if (ERR_RETRY == ao->error_num) { - pDoc->rpc.create_account(*ai); + retval = pDoc->rpc.create_account(*ai); + if (retval) break; } dtCurrentExecutionTime = wxDateTime::Now();