Rooba
/
boinc
mirror of https://github.com/BOINC/boinc.git
1
0
Fork 0
Code Issues 1 Packages Projects Releases Wiki Activity

vsprintf bug 

svn path=/trunk/boinc/; revision=1300
This commit is contained in:
Tim Lan 2003-06-04 21:27:30 +00:00
parent 9737331fb5
commit 4b98c0291d
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
client/client_state.C
View File

@ -1658,17 +1658,15 @@ int CLIENT_STATE::detach_project(PROJECT* project) {
// TODO: add translation functionality // TODO: add translation functionality
// //
void msg_printf(PROJECT *p, int priority, char *fmt, ...) { void msg_printf(PROJECT *p, int priority, char *fmt, ...) {
char buf[512], temp_buf[512]; char buf[512];
va_list ap; va_list ap;
if (fmt == NULL) return; if (fmt == NULL) return;
// Windows doesn't support vsnprintf, so we have to do // TODO: This is vulnerable to buffer overruns - FIX IT!
// this roundabout method to avoid buffer overruns
// //
safe_strncpy(temp_buf, fmt, sizeof(temp_buf)); va_start(ap, fmt); // Parses string for variables
va_start(ap, temp_buf); // Parses string for variables vsprintf(buf, fmt, ap); // And convert symbols To actual numbers
vsprintf(buf, temp_buf, ap); // And convert symbols To actual numbers
va_end(ap); // Results are stored in text va_end(ap); // Results are stored in text
show_message(p, buf, priority); show_message(p, buf, priority);