diff --git a/html/user/forum_banishment_vote.php b/html/user/forum_banishment_vote.php index 2163291a71..0ba99aebcd 100644 --- a/html/user/forum_banishment_vote.php +++ b/html/user/forum_banishment_vote.php @@ -39,6 +39,9 @@ if (!$logged_in_user->prefs->privilege(S_MODERATOR)) { $userid = get_int('userid'); $user = BoincUser::lookup_id($userid); +if (!$user) { + error_page('No such user.'); +} page_head(tra("Banishment Vote")); diff --git a/html/user/forum_banishment_vote_action.php b/html/user/forum_banishment_vote_action.php index ec6d51e20f..e794733795 100644 --- a/html/user/forum_banishment_vote_action.php +++ b/html/user/forum_banishment_vote_action.php @@ -48,6 +48,9 @@ if (!post_str('action', true)) { $userid = post_int('userid'); $user=BoincUser::lookup_id($userid); +if (!$user) { + error_page('No such user.'); +} if ($action!="start"){ error_page("Unknown action"); diff --git a/html/user/forum_moderate_post.php b/html/user/forum_moderate_post.php index a01a5faed4..de2d65170f 100644 --- a/html/user/forum_moderate_post.php +++ b/html/user/forum_moderate_post.php @@ -32,6 +32,9 @@ check_tokens($logged_in_user->authenticator); BoincForumPrefs::lookup($logged_in_user); $postid = get_int('id'); $post = BoincPost::lookup_id($postid); +if (!$post) { + error_page('No such post.'); +} $thread = BoincThread::lookup_id($post->thread); $forum = BoincForum::lookup_id($thread->forum); @@ -74,10 +77,10 @@ if (get_str('action')=="hide") { } elseif (get_str('action')=="banish_user") { $userid = get_int('userid'); $user = BoincUser::lookup_id($userid); - BoincForumPrefs::lookup($user); if (!$user) { error_page("no user found"); } + BoincForumPrefs::lookup($user); $x = $user->prefs->banished_until; if ($x>time()) { error_page(tra("User is already banished")); diff --git a/html/user/forum_moderate_thread.php b/html/user/forum_moderate_thread.php index 850544233c..fdf37310f3 100644 --- a/html/user/forum_moderate_thread.php +++ b/html/user/forum_moderate_thread.php @@ -32,6 +32,9 @@ if (!get_str('action')) { error_page("unknown action"); } $thread = BoincThread::lookup_id(get_int('thread')); +if (!$thread) { + error_page('No such thread.'); +} $forum = BoincForum::lookup_id($thread->forum); if (!is_moderator($logged_in_user, $forum)) { diff --git a/html/user/forum_post.php b/html/user/forum_post.php index 4d5890703d..25c885081c 100644 --- a/html/user/forum_post.php +++ b/html/user/forum_post.php @@ -38,6 +38,9 @@ if (VALIDATE_EMAIL_TO_POST) { $forumid = get_int("id"); $forum = BoincForum::lookup_id($forumid); +if (!$forum) { + error_page('No such forum.'); +} if (DISABLE_FORUMS && !is_admin($logged_in_user)) { error_page("Forums are disabled"); diff --git a/html/user/forum_rate.php b/html/user/forum_rate.php index fd90d3d862..76b59165ba 100644 --- a/html/user/forum_rate.php +++ b/html/user/forum_rate.php @@ -47,6 +47,9 @@ if (!empty($_GET['post'])) { } $post = BoincPost::lookup_id($postId); + if (!$post) { + error_page('No such post.'); + } $thread = BoincThread::lookup_id($post->thread); $forum = BoincForum::lookup_id($thread->forum); diff --git a/html/user/forum_reply.php b/html/user/forum_reply.php index 4193f43aa4..62738c384a 100644 --- a/html/user/forum_reply.php +++ b/html/user/forum_reply.php @@ -35,6 +35,9 @@ if (VALIDATE_EMAIL_TO_POST) { } $thread = BoincThread::lookup_id(get_int('thread')); +if (!$thread) { + error_page('No such thread.'); +} $forum = BoincForum::lookup_id($thread->forum); $sort_style = get_str('sort', true); diff --git a/html/user/forum_subscribe.php b/html/user/forum_subscribe.php index f21cf3136d..2124170d5c 100644 --- a/html/user/forum_subscribe.php +++ b/html/user/forum_subscribe.php @@ -29,6 +29,9 @@ check_get_args(array("action", "thread", "tnow", "ttok")); $action = get_str('action'); $threadid = get_int('thread'); $thread = BoincThread::lookup_id($threadid); +if (!$thread) { + error_page('No such thread.'); +} $forum = BoincForum::lookup_id($thread->forum); function show_title($forum, $thread) { diff --git a/html/user/forum_thread_vote.php b/html/user/forum_thread_vote.php index 66950dfa5f..2155d765b5 100644 --- a/html/user/forum_thread_vote.php +++ b/html/user/forum_thread_vote.php @@ -27,6 +27,9 @@ check_get_args(array("id")); $threadid = get_int('id'); $thread = BoincThread::lookup_id($threadid); +if (!$thread) { + error_page('No such thread.'); +} $logged_in_user = get_logged_in_user(); $posts = get_thread_posts($threadid, 0,true); diff --git a/html/user/forum_user_posts.php b/html/user/forum_user_posts.php index 740e50f89d..b2ae6ab0ab 100644 --- a/html/user/forum_user_posts.php +++ b/html/user/forum_user_posts.php @@ -26,11 +26,14 @@ if (DISABLE_FORUMS) error_page("Forums are disabled"); check_get_args(array("userid", "offset")); $userid = get_int("userid"); +$user = BoincUser::lookup_id($userid); +if (!$user) { + error_page("No such user."); +} $offset = get_int("offset", true); if (!$offset) $offset=0; $items_per_page = 20; -$user = BoincUser::lookup_id($userid); $logged_in_user = get_logged_in_user(false); BoincForumPrefs::lookup($logged_in_user);