Embedded comment describing start/end transaction bug. I'm too 'BOINCed'

to fix it.  David, your turn.

svn path=/trunk/boinc/; revision=5089
This commit is contained in:
Bruce Allen 2005-01-12 22:32:42 +00:00
parent 2fc2e2caa5
commit 3d5ea7f3c4
1 changed files with 5 additions and 0 deletions

View File

@ -334,6 +334,11 @@ static int send_results_for_file(
// if we couldn't send it for other reason, something's wacky;
// print a message, but keep on looking
//
// David, we DO arrive here at times! The reason is as follows, I
// think. You are missing a boinc_db.start_transaction *after* calling make_more_work_for_file()
// above. This means that possibly_send_result is not bracketed in a start/end transaction
// pair. Remember that make_more_work_for_file() sleeps AND modifies the DB.
if (retval) {
log_messages.printf(SCHED_MSG_LOG::CRITICAL,
"Database inconsistency? possibly_send_result() failed, returning %d\n", retval