Rooba
/
boinc
mirror of https://github.com/BOINC/boinc.git
1
0
Fork 0
Code Issues 1 Packages Projects Releases Wiki Activity

use snprintf to prevent buffer overflow 

fixes CID 27994 found by Coverity
also added sanity checks to fix CID 117636
This commit is contained in:
Christian Beer 2015-10-21 16:37:55 +02:00
parent e3b2140e18
commit 21df9b257b
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sched/size_regulator.cpp
View File

@ -83,6 +83,8 @@ int main(int argc, char** argv) {
log_messages.set_debug_level(atoi(argv[++i])); log_messages.set_debug_level(atoi(argv[++i]));
} else if (!strcmp(argv[i], "--sleep_time")) { } else if (!strcmp(argv[i], "--sleep_time")) {
sleep_time = atoi(argv[++i]); sleep_time = atoi(argv[++i]);
if (sleep_time < 0) sleep_time = 0;
if (sleep_time > 1000000) sleep_time = 1000000;
} else if (!strcmp(argv[i], "--random_order")) { } else if (!strcmp(argv[i], "--random_order")) {
order_clause = " order by random "; order_clause = " order by random ";
} else if (!strcmp(argv[i], "--priority_asc")) { } else if (!strcmp(argv[i], "--priority_asc")) {
@ -119,7 +121,7 @@ int main(int argc, char** argv) {
exit(1); exit(1);
} }
sprintf(buf, "where name='%s'", app_name); snprintf(buf, sizeof(buf), "where name='%s'", app_name);
if (app.lookup(buf)) { if (app.lookup(buf)) {
log_messages.printf(MSG_CRITICAL, "no such app: %s\n", app_name); log_messages.printf(MSG_CRITICAL, "no such app: %s\n", app_name);
exit(1); exit(1);