From 1a76ad2184810fc05437dc6ab47776fa90ffe4fa Mon Sep 17 00:00:00 2001
From: David Anderson <davea@ssl.berkeley.edu>
Date: Tue, 24 Jan 2006 22:41:47 +0000
Subject: [PATCH] require close tag in statefile

svn path=/trunk/boinc/; revision=9304
---
 checkin_notes         | 10 ++++++++--
 client/cs_statefile.C |  7 ++++++-
 2 files changed, 14 insertions(+), 3 deletions(-)

diff --git a/checkin_notes b/checkin_notes
index a9e7741ade..a47a8b289c 100755
--- a/checkin_notes
+++ b/checkin_notes
@@ -886,7 +886,7 @@ Rom    24 Jan 2006 (HEAD)
     - Tag for 5.3.14 release, all platforms
       boinc_core_release_5_3_14
 
-Rom    24 Jan 2005
+Rom    24 Jan 2006
     - Bug Fix: Remove the last line of the function that handles the 
         launching of the wizards on first execution which was causing
         the manager to switch over to the messages tab no matter if the
@@ -895,7 +895,7 @@ Rom    24 Jan 2005
     clientgui/
         MainFrame.cpp
 
-David  24 Jan 2005
+David  24 Jan 2006
 	- core client: move code that deals with generating new host CPID
 		to the end of handle_scheduler_reply(),
 		after the part that clears sched_rpc_pending and sets min_rpc_time,
@@ -921,3 +921,9 @@ David  24 Jan 2005
 		schema.sql
 	sched/
 		handle_request.C
+
+David  24 Jan 2006
+    - core client: statefile read fails if don't find </state_file>
+
+    client/
+        cs_statefile.C
diff --git a/client/cs_statefile.C b/client/cs_statefile.C
index d55edb5d4a..4e762b56fe 100644
--- a/client/cs_statefile.C
+++ b/client/cs_statefile.C
@@ -86,7 +86,7 @@ int CLIENT_STATE::parse_state_file() {
     while (fgets(buf, 256, f)) {
         if (match_tag(buf, "</client_state>")) {
             retval = 0;
-            break;
+            goto done;
         } else if (match_tag(buf, "<project>")) {
             PROJECT temp_project;
             retval = temp_project.parse_state(mf);
@@ -331,6 +331,11 @@ int CLIENT_STATE::parse_state_file() {
         } else if (parse_str(buf, "<newer_version>", newer_version)) {
         } else scope_messages.printf("CLIENT_STATE::parse_state_file: unrecognized: %s\n", buf);
     }
+
+    // if get here, we must have reached end of state file
+    // without finding </client_state> tag.
+    //
+    retval = ERR_XML_PARSE;
 done:
     fclose(f);