Rooba
/
boinc
mirror of https://github.com/BOINC/boinc.git
1
0
Fork 0
Code Issues 1 Packages Projects Releases Wiki Activity

VboxWrapper: prevent resource leak in FloppyIO::receive(string*) 

fixes CID 34512 found by Coverity
This commit is contained in:
Christian Beer 2015-11-10 16:34:46 +01:00
parent 8e9948e5d9
commit 155b35a3a2
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
samples/vboxwrapper/floppyio.cpp
View File

@ -275,17 +275,26 @@ int FloppyIO::receive(string * ansBuffer) {
char * dataToReceive = new char[this->szInput];
// Check for ready state
if (!this->ready()) return this->setError(-4, "Stream is not ready!");
if (!this->ready()) {
delete[] dataToReceive;
return this->setError(-4, "Stream is not ready!");
}
// If synchronized, wait for input data
if (this->synchronized) {
// Wait for input control byte to become 1
int iState = this->waitForSync(this->ofsCtrlByteIn, 1, this->syncTimeout);
if (iState<0) return iState;
if (iState<0) {
delete[] dataToReceive;
return iState;
}
}
// Check for stream status
if (!this->fIO->good()) return this->setError(-1, "I/O Stream reported no-good state while receiving!");
if (!this->fIO->good()) {
delete[] dataToReceive;
return this->setError(-1, "I/O Stream reported no-good state while receiving!");
}
// Read the input bytes from FD
this->fIO->seekg(this->ofsInput, ios_base::beg);
@ -298,6 +307,7 @@ int FloppyIO::receive(string * ansBuffer) {
// Copy input data to string object
*ansBuffer = dataToReceive;
dataToReceive = NULL;
return (int)ansBuffer->length();
}