Rooba
/
boinc
mirror of https://github.com/BOINC/boinc.git
1
0
Fork 0
Code Issues 1 Packages Projects Releases Wiki Activity

VBOX: If vboxmanage returns a CO_E_SERVER_EXEC_FAILURE error, go again and retry the command anyway. 

Vboxsvc may be running and working but some other oddity prevented vboxmanage from communicating with vboxsvc.  Evidence suggests future attempts may not fail.  Trace logs indicates that the clean-up routines did not fail when we attempted to cleanup the environment before reporting a failure.
This commit is contained in:
Rom Walton 2014-02-05 16:23:46 -05:00
parent 4b5a099f81
commit 106653ffe4
2 changed files with 29 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
samples/vboxwrapper/vbox.cpp
View File

@ -2681,9 +2681,34 @@ int VBOX_VM::vbm_popen(string& command, string& output, const char* item, bool l
sleep_interval *= 2;
}
}
// VboxManage has to be able to communicate with vboxsvc in order to actually issue a
// command. In cases where we detect CO_E_SERVER_EXEC_FAILURE, we should just automatically
// try the command again. Vboxmanage wasn't even able to issue the desired command
// anyway.
//
// Experiments performed by jujube suggest changing the sleep interval to an exponential
// style backoff would increase our chances of success.
//
// Error Code: CO_E_SERVER_EXEC_FAILURE (0x80080005)
//
if (CO_E_SERVER_EXEC_FAILURE == retval) {
if (retry_notes.find("Unable to communicate with VirtualBox") == string::npos) {
retry_notes += "Unable to communicate with VirtualBox. VirtualBox may need to\n";
retry_notes += "be reinstalled.\n\n";
}
if (retry_count) {
sleep_interval *= 2;
}
}
// Retry?
if (!retry_failures) break;
if (!retry_failures &&
(VBOX_E_INVALID_OBJECT_STATE != retval) &&
(CO_E_SERVER_EXEC_FAILURE != retval)
) {
break;
}
// Timeout?
if (retry_count >= 5) break;

3
samples/vboxwrapper/vbox.h
View File

@ -23,6 +23,9 @@
// Known VirtualBox/COM error codes
//
#ifndef CO_E_SERVER_EXEC_FAILURE
#define CO_E_SERVER_EXEC_FAILURE 0x80080005
#endif
#ifndef RPC_S_SERVER_UNAVAILABLE
#define RPC_S_SERVER_UNAVAILABLE 0x800706ba
#endif