From 0da4c42976a851518fe9725fb6aacd21ecf09ae3 Mon Sep 17 00:00:00 2001
From: "Janus B. Kristensen" <jbk@visualgroup.dk>
Date: Sun, 5 Oct 2008 12:45:33 +0000
Subject: [PATCH] Having variables called 1, 2, 3... etc is really bad coding
 style and causes buckloads of issues in associative arrays. Instead call them
 stuff like "role1", "role2" and so on.

svn path=/trunk/boinc/; revision=16132
---
 html/ops/manage_special_users.php        | 4 ++--
 html/ops/manage_special_users_action.php | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/html/ops/manage_special_users.php b/html/ops/manage_special_users.php
index 820b9ea9da..d6e4960b19 100644
--- a/html/ops/manage_special_users.php
+++ b/html/ops/manage_special_users.php
@@ -42,7 +42,7 @@ for($i=1;$i<=mysql_num_rows($result);$i++){
           <tr><td>$foo->name</td>";
     for ($j=0;$j<=6;$j++) {
         $bit = substr($foo->special_user, $j, 1);
-        echo "<td><input type=\"checkbox\" name=\"".$j."\" value=\"1\"";
+        echo "<td><input type=\"checkbox\" name=\"role".$j."\" value=\"1\"";
         if ($bit == 1) {
             echo " checked=\"checked\"";
         }
@@ -56,7 +56,7 @@ echo "<tr><form action=\"manage_special_users_action.php\" method=\"POST\">\n";
 echo "<td>Add UserID:<input type=\"text\" name=\"userid\" size=\"6\"></td>";
 
 for ($j=0;$j<=6;$j++) {
-        echo "<td><input type=\"checkbox\" name=\"".$j."\" value=\"1\"";
+        echo "<td><input type=\"checkbox\" name=\"role".$j."\" value=\"1\"";
         echo "></td>\n";
     }
     echo "<td><input type=\"submit\" value=\"Update\"></form></td>";
diff --git a/html/ops/manage_special_users_action.php b/html/ops/manage_special_users_action.php
index dd1ddd758f..82d1f8b3e7 100644
--- a/html/ops/manage_special_users_action.php
+++ b/html/ops/manage_special_users_action.php
@@ -26,7 +26,7 @@ admin_page_head("Manage special users action");
 $bitset = '';
 
 for ($i=0;$i<=6;$i++) {
-    if (post_int($i, TRUE) == '1') {
+    if (post_int("role".$i, TRUE) == '1') {
         $bitset = str_pad($bitset, $i+1, '1');
     } else {
         $bitset = str_pad($bitset, $i+1, '0');