From 03fb7929c937e56dd1668f7c383c42b80dceff5a Mon Sep 17 00:00:00 2001 From: Rom Walton Date: Wed, 20 May 2009 21:48:09 +0000 Subject: [PATCH] - MGR: Fix bug where there was no trailing backslash before 'symbols' was appended to the end of the symbol path. This caused the stack tracing code not to download the actual symbol files needed to debug a problem. I have no idea when this bug was introduced. lib/ stackwalker_win.cpp svn path=/trunk/boinc/; revision=18172 --- checkin_notes | 10 ++++++++++ lib/stackwalker_win.cpp | 4 ++-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/checkin_notes b/checkin_notes index a420db3b6a..b7728ce436 100644 --- a/checkin_notes +++ b/checkin_notes @@ -4670,3 +4670,13 @@ Rom 20 May 2009 clientgui/ MainDocument.cpp + +Rom 20 May 2009 + - MGR: Fix bug where there was no trailing backslash before + 'symbols' was appended to the end of the symbol path. This + caused the stack tracing code not to download the actual + symbol files needed to debug a problem. I have no idea + when this bug was introduced. + + lib/ + stackwalker_win.cpp diff --git a/lib/stackwalker_win.cpp b/lib/stackwalker_win.cpp index 7b921de114..b4e1d629cf 100644 --- a/lib/stackwalker_win.cpp +++ b/lib/stackwalker_win.cpp @@ -594,9 +594,9 @@ int DebuggerInitialize( LPCSTR pszBOINCLocation, LPCSTR pszSymbolStore, BOOL bPr // [DATADIR]\projects\project_dir\symbols // if (!diagnostics_is_flag_set(BOINC_DIAG_BOINCAPPLICATION)) { - strLocalSymbolStore += strCurrentDirectory + std::string("symbols"); + strLocalSymbolStore += strCurrentDirectory + std::string("\\symbols"); } else { - strLocalSymbolStore += strExecutableDirectory + std::string("symbols"); + strLocalSymbolStore += strExecutableDirectory + std::string("\\symbols"); } // Microsoft Public Symbol Server