From 00208473053f9348658f59f0aade82705a891f73 Mon Sep 17 00:00:00 2001 From: Charlie Fenton Date: Wed, 19 Nov 2008 07:46:53 +0000 Subject: [PATCH] Add some comments svn path=/trunk/boinc/; revision=16534 --- clientgui/AsyncRPC.cpp | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/clientgui/AsyncRPC.cpp b/clientgui/AsyncRPC.cpp index 268c5642d2..e29565acff 100755 --- a/clientgui/AsyncRPC.cpp +++ b/clientgui/AsyncRPC.cpp @@ -511,10 +511,13 @@ int CMainDocument::RequestRPC(ASYNC_RPC_REQUEST& request, bool hasPriority) { // Don't show dialog while Manager is minimized, but do // process events so user can maximize the manager. // - // NOTE: CBOINCGUIApp::FilterEvent() blocks those events + // NOTE: CBOINCGUIApp::FilterEvent() discards those events // which might cause posting of more RPC requests while // we are in this loop, to prevent undesirable recursion. - // It does allow wxEVT_RPC_FINISHED. + // Since the manager is minimized, we don't have to worry about + // discarding crucial drawing or command events. + // The filter does allow the the Open Manager menu item from + // the system tray icon and wxEVT_RPC_FINISHED event. // timeToSleep = DELAY_WHEN_MINIMIZED; // Allow user to maximize Manager wxSafeYield(NULL, true); @@ -530,6 +533,8 @@ int CMainDocument::RequestRPC(ASYNC_RPC_REQUEST& request, bool hasPriority) { // Simulate handling of CRPCFinishedEvent but don't allow any other // events (so no user activity) to prevent undesirable recursion. + // Since we don't need to filter and discard events, they remain on + // the queue until it is safe to process them. // Allow RPC thread to run while we wait for it. if (!current_rpc_request.isActive) { mutexErr = m_pRPC_Request_Mutex->Unlock();