Rooba
/
bidict
mirror of https://github.com/jab/bidict.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity

more efficient OrderedBidirectionalMapping.__eq__ impl 

when other is an unordered mapping. Mapping.__eq__() creates a
temporary dict (passing self) before comparing and then throws it
away. Avoiding that implementation avoids the unnecessary malloc.
This commit is contained in:
jab 2016-06-29 23:07:51 +00:00
parent d358f82ca3
commit 9c004aa9b4
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
bidict/_ordered.py
View File

@ -17,7 +17,7 @@ def _make_iter(reverse=False, name='__iter__', doctmpl='Like :meth:`collections.
def _iter(self): def _iter(self):
fwd = self._fwd fwd = self._fwd
end = self._end end = self._end
cur = end[_PRV] if reverse else end[_NXT] cur = end[_PRV if reverse else _NXT]
while cur is not end: while cur is not end:
d, prv, nxt = cur d, prv, nxt = cur
korv = next(iter(d)) korv = next(iter(d))
@ -182,9 +182,12 @@ class OrderedBidirectionalMapping(BidirectionalMapping):
if i != j: if i != j:
return False return False
return True return True
if isinstance(other, Mapping): if not isinstance(other, Mapping) or len(self) != len(other):
return Mapping.__eq__(self, other) return False
return False for (k, v) in iteritems(other):
if self.get(k, _missing) != v:
return False
return True
def __repr__(self): def __repr__(self):
inner = ', '.join('(%r, %r)' % (k, v) for (k, v) in iteritems(self)) inner = ', '.join('(%r, %r)' % (k, v) for (k, v) in iteritems(self))