From dcf8a9f5f0894fb6fe840f0ad1efea5caf3e535d Mon Sep 17 00:00:00 2001 From: Nick Bolton Date: Sat, 21 Mar 2015 19:05:43 +0000 Subject: [PATCH] Changed use of popen to getstatusoutput #4464 The getstatusoutput function seems easier to use --- ext/toolchain/commands1.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/ext/toolchain/commands1.py b/ext/toolchain/commands1.py index 45141701..4355f982 100644 --- a/ext/toolchain/commands1.py +++ b/ext/toolchain/commands1.py @@ -775,13 +775,12 @@ class InternalCommands: if sys.version_info < (2, 4): raise Exception("Python 2.4 or greater required.") - output = os.popen( + output = commands.getstatusoutput( "macdeployqt %s/Synergy.app -verbose=2 -codesign='%s'" % ( - targetDir, self.macIdentity)).read() + targetDir, self.macIdentity)) - print output - - if "ERROR" in output: + print output[1] + if "ERROR" in output[1]: raise Exception("macdeployqt failed") def signmac(self):