* Don't reset custom __setattr__ in slotted classes
Fixes#680
Signed-off-by: Hynek Schlawack <hs@ox.cx>
* Simplify
Signed-off-by: Hynek Schlawack <hs@ox.cx>
* Be defensive about __bases__
Signed-off-by: Hynek Schlawack <hs@ox.cx>
* _Classes_ always have a __dict__
* Tighten xfail
* Clarify what need to be reset and when
Signed-off-by: Hynek Schlawack <hs@ox.cx>
* Reset __attrs_own_setattr__ along with __setattr__
Signed-off-by: Hynek Schlawack <hs@ox.cx>
* Update src/attr/_make.py
Co-authored-by: Paul Ganssle <paul@ganssle.io>
* Differentiate between own (= attrs) and custom (= user) __setattrs__
Signed-off-by: Hynek Schlawack <hs@ox.cx>
* We've always used __bases__ in our call to type()
So no reason for being defensive.
* Update tests/test_setattr.py
Co-authored-by: Paul Ganssle <paul@ganssle.io>
Co-authored-by: Paul Ganssle <paul@ganssle.io>
* Add attr.auto/mutable/frozen
Prepare for import attrs y'all!
Signed-off-by: Hynek Schlawack <hs@ox.cx>
* Try combining coverage using 3.8, always
* Add tests for overriding of auto_attribs
* Clarifications
* Add newsfragment
* s/auto/define
This is going be the next-gen name anyways, so no need to introduce new names.
Signed-off-by: Hynek Schlawack <hs@ox.cx>
* Missed two
* Add type stubs
* Beg for patience
* Explain second setup-python action
* fix comment
* Add attr.resolve_types
This adds `attr.resolve_types` which can be used to resolve forward declarations in classes created using `__annotations__`
Fixes#265
* Fix flake8 and doctest
* Missed one
* Fix lint
* Address CR comments
Add to stubs
Make it a decorator, because why not?
* Fix test
* Rerun-tests please
* Rerun-tests please
* Fix another
* Fix lint
Co-authored-by: David Euresti <david@zapgram.com>
* Add on_setattr hooks to attr.s and attr.ib
Signed-off-by: Hynek Schlawack <hs@ox.cx>
* Add PR newsfragment
* Fix attr.s doc sig
* Make _DisableType private
* Mark setters.frozen as NoReturn
* Rename setters.DISABLE to setters.NO_OP to clarify its purpose
DISABLE sounds less purposeful and doesn't convey its meaning as well.
* Fix type
* Loosen up type for convert even further
* Tighten type a tiny bit
* Add control to generate __[sg]etstate__
Pass *getstate_setstate* to attr.s to control the generation. Mostly
interesting for disabling it in slotted classes.
Fixes #512,#513
* Update glossary.rst
* Implement auto_detect
Fixes#324
* Add test demonstrating total_ordering
* Ensure the order of applying total_ordering does not matter
* Warn if a method is missing
* Revert "Warn if a method is missing"
This reverts commit 590ef43458040e0a1b9f3644ba22b4229f7d6990.
* Add stern warning that nobody will read
* from parsyfiles development (https://github.com/smarie/python-simple-file-collection-parsing-framework):
* added new 'chain' validator to allow users to chain their custom validators with, for example, 'instance_of'
* added utility methods to get the declared attribute type (by inspecting its validators) and to check if it is optional
* from parsyfiles development (https://github.com/smarie/python-simple-file-collection-parsing-framework):
* added tests
* fixed bug with optional validator to pass tests :)
* from parsyfiles development (https://github.com/smarie/python-simple-file-collection-parsing-framework):
* completed doc api.rst
* small mod in tests
* Fixed issue with empty cell in closure when slots are used. Fixed#589
* Removed api.rst mods erroneously injected from another branch.
* Removed api.rst mods erroneously injected from another branch.
* noqa so that flake8 is happy
* Fixed lint error
* Added towncrier changelog entry
* Attempt to fix linter error
* Update tests/test_slots.py
* Last lint fix
* Update changelog.d/590.change.rst
Co-Authored-By: Hynek Schlawack <hs@ox.cx>
* Added extensive doc in the new test
* Update tests/test_slots.py
* last lint error
Co-authored-by: Sylvain MARIE <sylvain.marie@se.com>
Co-authored-by: Hynek Schlawack <hs@ox.cx>
* Wrapped __ne__ in a _make_ne function to guarantee that each attrs class gets a new instance of the __ne__ function
* Changed _make_eq to return just __eq__ instead of __eq__ and __ne__
Co-authored-by: Hynek Schlawack <hs@ox.cx>
* Use an self-clearing subclass to store hash cache
Rather than attempting to remove the hash cache from the object state on
deserialization or serialization, instead we store the hash cache in an
object that reduces to None, thus clearing itself when pickled or
copied.
This fixes GH #494 and #613.
Co-authored-by: Matt Wozniski <godlygeek@gmail.com>
* Add test for two-argument __reduce__
I couldn't think of any way to make a useful and meaningful class that
has no state and also has no custom __reduce__ method, so I went
minimalist with it.
* Improve test for hash clearing behavior.
Previously, there was some miniscule risk of hash collision, and also it
was relying on the implementation details of `pickle` (the assumption
that `hash()` is never called as part of `pickle.loads`).
* Add improved testing around cache_hash
* Update src/attr/_make.py
Co-Authored-By: Ryan Gabbard <gabbard@isi.edu>
* Update comment in slots_setstate
Since the cached hash value is not actually serialized in __getstate__,
__setstate__ is not actually "clearing" it on deserialization - it's
initializing the value to None.
* Add changelog entry
* Remove changelog for #611
This change was overshadowed by a more fundamental change in #620.
Co-authored-by: Matt Wozniski <godlygeek@gmail.com>
Co-authored-by: Ryan Gabbard <gabbard@isi.edu>
* Add xfailing test for frozen/cache_hash issue
This is a failing test for GH issue #611, with the xfail decorator to be
removed when the issue is fixed.
* Fix incompatibility between frozen and cache_hash
Fixes GH issue #611: serialization of a class with frozen=True and
cache_hash=True will now succeed rather than raising a
FrozenInstanceError.
Co-authored-by: Hynek Schlawack <hs@ox.cx>
* Add attr.__version_info__
This allows users to check for features and avoid deprecation warnings without
breaking backward compatibility.
* Add newsfragment
* Stay ASCII
* Typo
* Add stubs for _version.py
* Address David's feedback
* Handle PY2 better in comparability test
* drop the ing
* Split cmp into eq and order
Fixes#170
* Fix tests on old pypy3 versions
Old as in: currently on AP.
* Fix issue number and clarify newsfragment
* Clarify behavior and interaction between cmp/eq/order
* This sounds better
* Address Julian's review comments
* Missed a cmp
* Test the behavior of Attribute.cmp
* Make test more idiomatic
* Explain assumptions
* Clarify comment
* Grammar
* One more cmp!
* Add default_role for Sphinx.
Fix a bunch of broken refs along the way, which become
errors now via -W if you have default_role set.
In theory you can catch those via sphinx-build -n (i.e.
nitpick mode), which IMHO is a decent idea anyhow, but it's
a longer diff to enable that because it'd involve fixing a
bunch of the places that try to reference types that don't
exist (e.g. :type foo: Any value). But obviously can be done.
Also didn't actually use this anywhere yet (the any role),
but will do so in a follow-up if this is acceptable.
* Remove the roles from builtin objects to demo any.
* Style.
* Add z.i to intersphinx.
Enables the link to z.i.Interface.
* Enable nitpick mode.
Fix the remaining broken links or whitelist them via nitpick_ignore.
* Kill all :func:s.
* Kill all :class:es.
* Kill all :doc:s.
* Kill all :ref:s.
Except one, that probably meant :func:, and which
is a duplicate ref.
* Kill :exc: and :data:.
* Kill :mod:s.
* Kill new explicit refs from the merge.
* matches
* added flags pass-through, and multiple function options; defaults to fullmatch
* move logic from validate to constructor
* cleaned up default args / fullmatch emulation
* fixed meta validator
* cleaned up default args / fullmatch emulation
* test cleanup
* versionadded tag
* added changelog entry
* cleaned up type checks, added to api docs and pyi type signature
* black formats
* black formatting
* 100% test coverage
* added example usage of matches_re to docs
* fixing py2 swallow type error and wrong quote in doctest
* explicit tests for all possible func args
* pragma no branch to get coverage 100%
* wip: support custom repr() callable for attributes
see #567
* extend ‘repr=...’ arg type in .pyi stubs
* expand docstring for attr.ib()
* add changelog entry
* add docs with example
* improve my copy/paste skills 🙈
* fix grammar
* fix typo in changelog entry
* fix and improve attrib() docstring
* detect custom repr() once, not per call. be strict about bool.
* use rst syntax, not markdown
* apply hynek's suggestions for changelog entry
* add ‘versionchanged’ note in docstring
* add custom attribute repr= to typing example
* simplify comment
* Ability to disable the keyword-only order checks that forbid normal attrs after kw_only attrs
* Updated typing info
* Updated tests, and added a new test for the new ordering feature
* Pep8
* Updated docstring
* Rename to a name that reflects the usage, not the implementation
* Update tests after the rename
* Huge simplification: never check kw_only and non-init attributes order
* No more new parameter, remove from typing info
* Update tests after the simplification, and add new test
* Revert "Don't use CodeType.replace() -- it was added in 3.8.0b1, but CI still uses 3.8.0a4"
Our CI now supports CodeType.replace(), and the only 3.8 versions that don't support it are alpha releases so we don't need to maintain support for them. Using replace() is more forward compatible.
This reverts commit 52097ce321.
* Disable forced-failure test on 3.8+ -- there's no longer enough surface area for a monkeypatch to do anything
* Make unique_filename not depend on repr.
For debugging purposes, when a method is created it needs to be put
into a "filename". This filename was generated using `repr(attrs)`
however this meant that the filename could change every time the
program was loaded depending on the whims of repr. (In particular
free functions and lambdas would include ids)
This solves the problem by changing the name to be <attrs generated
{method} {module}.{qualname}> If it should happen that the name is
taken then -2 will be appended and incremented until a free filename
is found.
* Add tests
* Fix tests and changelog
Hynek Schlawack