From d528dd425980eff3f43b0e29b0ce4dc81ecd8d84 Mon Sep 17 00:00:00 2001 From: Hynek Schlawack Date: Tue, 28 Dec 2021 06:47:51 +0100 Subject: [PATCH] Fix more links --- CHANGELOG.rst | 2 +- docs/conf.py | 4 ++++ docs/types.rst | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index d6b2ba43..7c532bc4 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -115,7 +115,7 @@ Changes See the `new docs on comparison `_ for more details. `#787 `_ -- Added **provisional** support for static typing in ``pyright`` via the `dataclass_transforms specification `_. +- Added **provisional** support for static typing in ``pyright`` via the `dataclass_transforms specification `_. Both the ``pyright`` specification and ``attrs`` implementation may change in future versions of both projects. Your constructive feedback is welcome in both `attrs#795 `_ and `pyright#1782 `_. diff --git a/docs/conf.py b/docs/conf.py index 56d91b13..0cc80be6 100644 --- a/docs/conf.py +++ b/docs/conf.py @@ -10,7 +10,11 @@ from attr import define, frozen, field, validators, Factory """ linkcheck_ignore = [ + # We run into GitHub's rate limits. r"https://github.com/.*/(issues|pull)/\d+", + # It never finds the anchor even though it's there. + "https://github.com/microsoft/pyright/blob/main/specs/" + "dataclass_transforms.md#attrs", ] # In nitpick mode (-n), still ignore any of the following "broken" references diff --git a/docs/types.rst b/docs/types.rst index 4c6a47c8..fbb90a7e 100644 --- a/docs/types.rst +++ b/docs/types.rst @@ -96,7 +96,7 @@ Given the following definition, ``pyright`` will generate static type signatures - The ``attr.frozen`` decorator is not typed with frozen attributes, which are properly typed via ``attr.define(frozen=True)``. - A `full list `_ of limitations and incompatibilities can be found in pyright's repository. + A `full list `_ of limitations and incompatibilities can be found in pyright's repository. Your constructive feedback is welcome in both `attrs#795 `_ and `pyright#1782 `_. Generally speaking, the decision on improving ``attrs`` support in pyright is entirely Microsoft's prerogative though.