From 90f7590abf70e1405295387cac214485af411e3e Mon Sep 17 00:00:00 2001 From: Sviatoslav Sydorenko Date: Sun, 18 Dec 2022 11:46:08 +0100 Subject: [PATCH] Add unstable Python 3.12 to CI allowing failures (#1033) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Add unstable Python 3.12 to CI allowing failures * 🔧 Add a toxenv for 🐍 Python 3.12 * Account for 3.12 abc error @ test_remain_abstract Co-authored-by: Hynek Schlawack --- .github/workflows/ci.yml | 4 ++++ src/attr/_compat.py | 1 + tests/test_abc.py | 12 ++++++++---- tox.ini | 5 +++-- 4 files changed, 16 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 80ef440e..433af99c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -34,9 +34,13 @@ jobs: - "3.9" - "3.10" - "3.11" + - "~3.12.0-0" - "pypy-3.7" - "pypy-3.8" + continue-on-error: >- + ${{ contains(matrix.python-version, '~') && true || false }} + steps: - name: Harden Runner uses: step-security/harden-runner@v2 diff --git a/src/attr/_compat.py b/src/attr/_compat.py index cc98c88b..35a85a3f 100644 --- a/src/attr/_compat.py +++ b/src/attr/_compat.py @@ -13,6 +13,7 @@ from collections.abc import Mapping, Sequence # noqa PYPY = platform.python_implementation() == "PyPy" PY310 = sys.version_info[:2] >= (3, 10) +PY_3_12_PLUS = sys.version_info[:2] >= (3, 12) def just_warn(*args, **kw): diff --git a/tests/test_abc.py b/tests/test_abc.py index d5682b46..a70b317a 100644 --- a/tests/test_abc.py +++ b/tests/test_abc.py @@ -7,7 +7,7 @@ import pytest import attrs -from attr._compat import PY310 +from attr._compat import PY310, PY_3_12_PLUS @pytest.mark.skipif(not PY310, reason="abc.update_abstractmethods is 3.10+") @@ -50,7 +50,11 @@ class TestUpdateAbstractMethods: pass assert inspect.isabstract(StillAbstract) - with pytest.raises( - TypeError, match="class StillAbstract with abstract method foo" - ): + expected_exception_message = ( + "^Can't instantiate abstract class StillAbstract without an " + "implementation for abstract method 'foo'$" + if PY_3_12_PLUS + else "class StillAbstract with abstract method foo" + ) + with pytest.raises(TypeError, match=expected_exception_message): StillAbstract() diff --git a/tox.ini b/tox.ini index b6308ad1..0a31e9c7 100644 --- a/tox.ini +++ b/tox.ini @@ -7,11 +7,12 @@ python = 3.9: py39 3.10: py310, mypy 3.11: py311 + 3.12: py312 pypy-3: pypy3 [tox] -envlist = mypy,pre-commit,py36,py37,py38,py39,py310,py311,pypy3,pyright,manifest,docs,pypi-description,changelog,coverage-report +envlist = mypy,pre-commit,py36,py37,py38,py39,py310,py311,py312,pypy3,pyright,manifest,docs,pypi-description,changelog,coverage-report isolated_build = True @@ -42,7 +43,7 @@ setenv = commands = {[testenv:py36]commands} -[testenv:py311] +[testenv:py31{1,2}] extras = cov # Python 3.6+ has a number of compile-time warnings on invalid string escapes. # PYTHONWARNINGS=d and --no-compile below make them visible during the Tox run.