Rooba
/
attrs
mirror of https://github.com/python-attrs/attrs.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity
attrs/changelog.d/1303.change.md

2 lines
46 B
Markdown
Raw Normal View History

Add `attrs.validators.or_` validator (#1303) * Implement attrs.validators.or_ validator * Add tests/test_validators.py::TestOr test cases * Add test for _OrValidator.__repr__ method * Add description of attrs.validators.or_ to docs/api.rst * Add changelog entry * Swap double quotes for single because doctests don't like it * Rename changelog fragment pointing to incorrect number * Silence ruff linter warnings Although good warning in general, in this particular code, they do not fit here. * BLE001 Do not catch blind exception: `Exception` `validators` usually raise `ValueError` upon their violation. However, it's not the only `Exception` they can raise - cf. `attrs.validators.not_` - therefore, it is desirable to catch them all! * PERF203 `try`-`except` within a loop incurs performance overhead Fair point, but the loop is written in a way to short-circuit, ie. it will finish when a first validator is satisfied. * S112 `try`-`except`-`continue` detected, consider logging the exception Not applicable here, we care only if **all** validators raise an exception, which is already accomodated for after the `for` loop. * Apply suggestions from code review Co-authored-by: Hynek Schlawack <hs@ox.cx> * Rework example of or_ validator in api/docs.rst * Update docs/api.rst --------- Co-authored-by: Hynek Schlawack <hs@ox.cx> Co-authored-by: Libor <libas.martinek@protonmail.com>
2024-07-17 12:01:41 +00:00
Added the `attrs.validators.or_()` validator.