diff --git a/css/userChrome-files/bookmarks_popup.css b/css/userChrome-files/bookmarks_popup.css index eae2b2d..207f9dd 100644 --- a/css/userChrome-files/bookmarks_popup.css +++ b/css/userChrome-files/bookmarks_popup.css @@ -70,7 +70,22 @@ url(chrome://browser/content/places/bookmarkProperties2.xul) { #bookmarkproperties { -moz-appearance: none!important; color: var(--in-content-page-color)!important; - background-color: var(--in-content-box-background)!important + background-color: var(--in-content-category-header-background)!important + } + textbox { + -moz-appearance: none!important; + min-height: 20px!important; + padding: 2px!important; + border: 1px solid var(--in-content-box-border-color); + color: var(--in-content-page-color)!important; + background: var(--in-content-box-background)!important + } + #editBMPanel_folderTree { + background: var(--in-content-box-background)!important + } + #editBMPanel_folderMenuList { + background-color: var(--in-content-box-background)!important; + padding: 2px!important } #editBMPanel_foldersExpander.expander-down, #editBMPanel_tagsSelectorExpander.expander-down { @@ -99,4 +114,7 @@ url(chrome://browser/content/places/bookmarkProperties2.xul) { border-radius: 3px; border-color: var(--in-content-box-border-color)!important } + #editBMPanel_newFolderBox { + background: 0 0!important + } } \ No newline at end of file diff --git a/no_empty_iframes/no_empty_iframes.zip b/no_empty_iframes/no_empty_iframes.zip new file mode 100644 index 0000000..0c4ec72 Binary files /dev/null and b/no_empty_iframes/no_empty_iframes.zip differ diff --git a/no_empty_iframes/testpage.html b/no_empty_iframes/testpage.html deleted file mode 100644 index e69de29..0000000 diff --git a/userChrome.css b/userChrome.css index 8aef864..fce13f8 100644 --- a/userChrome.css +++ b/userChrome.css @@ -692,7 +692,22 @@ url(chrome://browser/content/places/bookmarkProperties2.xul) { #bookmarkproperties { -moz-appearance: none!important; color: var(--in-content-page-color)!important; - background-color: var(--in-content-box-background)!important + background-color: var(--in-content-category-header-background)!important + } + textbox { + -moz-appearance: none!important; + min-height: 20px!important; + padding: 2px!important; + border: 1px solid var(--in-content-box-border-color); + color: var(--in-content-page-color)!important; + background: var(--in-content-box-background)!important + } + #editBMPanel_folderTree { + background: var(--in-content-box-background)!important + } + #editBMPanel_folderMenuList { + background-color: var(--in-content-box-background)!important; + padding: 2px!important } #editBMPanel_foldersExpander.expander-down, #editBMPanel_tagsSelectorExpander.expander-down { @@ -721,6 +736,9 @@ url(chrome://browser/content/places/bookmarkProperties2.xul) { border-radius: 3px; border-color: var(--in-content-box-border-color)!important } + #editBMPanel_newFolderBox { + background: 0 0!important + } } @-moz-document url("chrome://global/content/commonDialog.xul") { #commonDialog { diff --git a/website/no_empty_iframes/README.md b/website/no_empty_iframes/README.md deleted file mode 100644 index c80b6e9..0000000 --- a/website/no_empty_iframes/README.md +++ /dev/null @@ -1,24 +0,0 @@ -# No Empty iframes - -## What it does - -No Empty iframes adds a blank `div` to any iframes that have an empty `body`. - -## That sounds useless...what's the point? - -[ShadowFox](https://github.com/overdodactyl/ShadowFox) utilizes `userContent.css` and `userChrome.css` to create a universal dark theme for Firefox. In part, this means styling `about:blank`. A complication of this is that `about:blank` is also used for anonymous frames on webpages. Generally, iframes will contain content, making the following css rule specific enough: - -```css -html > body:empty { - background-color: var(--in-content-page-background)!important; - margin: 0!important -} -``` - -Some pages, however, have empty iframes that cause readability issues (see [#222](https://github.com/overdodactyl/ShadowFox/issues/222)). - -This extension injects an empty div into such iframes, allowing the rule above to work. - -## Better approaches? - -If anyone has a better approach/workaround for this problem, I would appreciate any suggestions. \ No newline at end of file diff --git a/website/no_empty_iframes/manifest.json b/website/no_empty_iframes/manifest.json deleted file mode 100644 index 13ee691..0000000 --- a/website/no_empty_iframes/manifest.json +++ /dev/null @@ -1,17 +0,0 @@ -{ - - "description": "Add an empty div to the body of any empty iframes. Supplemental addon to ShadowFox.", - "manifest_version": 2, - "name": "No Empty iframes", - "version": "1.0", - "homepage_url": "https://github.com/overdodactyl/ShadowFox/no_empty_iframes", - - "content_scripts": [ - { - "matches": [""], - "js": ["no_empty_iframes.js"], - "run_at": "document_end" - } - ] - -} diff --git a/website/no_empty_iframes/no_empty_iframes.js b/website/no_empty_iframes/no_empty_iframes.js deleted file mode 100644 index 05a29b0..0000000 --- a/website/no_empty_iframes/no_empty_iframes.js +++ /dev/null @@ -1,12 +0,0 @@ -/* Once page finishes loading, find all empty iframes - * and add empty div inside */ -window.onload = function() { - var frames = document.getElementsByTagName("iframe"); - for (var i = 0; i < frames.length; i++) { - var doc = frames[i].contentWindow.document; - if (doc.body.innerHTML === "") { - var elemDiv = document.createElement('div'); - doc.body.appendChild(elemDiv); - } - } -} diff --git a/website/no_empty_iframes/no_empty_iframes.zip b/website/no_empty_iframes/no_empty_iframes.zip deleted file mode 100644 index 31feefd..0000000 Binary files a/website/no_empty_iframes/no_empty_iframes.zip and /dev/null differ diff --git a/website/no_empty_iframes/readme.html b/website/no_empty_iframes/readme.html deleted file mode 100644 index 0c5028b..0000000 --- a/website/no_empty_iframes/readme.html +++ /dev/null @@ -1,13 +0,0 @@ -

No Empty iframes

-

What it does

-

No Empty iframes adds a blank div to any iframes that have an empty body.

-

That sounds useless…what’s the point?

-

ShadowFox utilizes userContent.css and userChrome.css to create a universal dark theme for Firefox. In part, this means styling about:blank. A complication of this is that about:blank is also used for anonymous frames on webpages. Generally, iframes will contain content, making the following css rule specific enough:

-
html > body:empty {
-    background-color: var(--in-content-page-background)!important;
-    margin: 0!important
-}
-

Some pages, however, have empty iframes that cause readability issues (see #222).

-

This extension injects an empty div into such iframes, allowing the rule above to work.

-

Better approaches?

-

If anyone has a better approach/workaround for this problem, I would appreciate any suggestions.