Rooba
/
ReC98
mirror of https://github.com/nmlgc/ReC98.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity
ReC98/th02/formats/pi_slot_load.asm

35 lines
558 B
NASM
Raw Normal View History

Use TASM calling convention syntax for previously identified ZUN functions With TH03 changing the calling convention for most of the code from __cdecl to __pascal, I've been getting more and more confused about this myself. So, let's settle on the following consistent syntax for function calls: * C where the calling convention is actually __cdecl and where TASM's emitted __cdecl code matches the original binary * PASCAL where the calling convention is actually __pascal * STDCALL where the calling convention is actually __cdecl, but where the caller either defers stack cleanup (summing up the stack size of multiple functions, then cleaning it all in a single "add sp" instruction) or where the stack is cleared in a different way (e.g. "pop cx"). Unfortunately though, when using the ARG directive to automatically generate an appropriate RET instruction for the given calling convention, TASM always emits ENTER and LEAVE instructions even when no local variables are declared, which greatly limits the number of functions where we can use that syntax. -.-
2014-12-16 04:53:56 +00:00
; int DEFCONV pi_slot_load(int slot, char *fn)
proc_defconv pi_slot_load
arg @@slot:word, @@fn:dword
local @@ret
[Reverse-engineering] Slot-based PI file loading and freeing
2014-11-18 16:56:13 +00:00
push si
Use TASM calling convention syntax for previously identified ZUN functions With TH03 changing the calling convention for most of the code from __cdecl to __pascal, I've been getting more and more confused about this myself. So, let's settle on the following consistent syntax for function calls: * C where the calling convention is actually __cdecl and where TASM's emitted __cdecl code matches the original binary * PASCAL where the calling convention is actually __pascal * STDCALL where the calling convention is actually __cdecl, but where the caller either defers stack cleanup (summing up the stack size of multiple functions, then cleaning it all in a single "add sp" instruction) or where the stack is cleared in a different way (e.g. "pop cx"). Unfortunately though, when using the ARG directive to automatically generate an appropriate RET instruction for the given calling convention, TASM always emits ENTER and LEAVE instructions even when no local variables are declared, which greatly limits the number of functions where we can use that syntax. -.-
2014-12-16 04:53:56 +00:00
mov si, @@slot
[Reverse-engineering] Slot-based PI file loading and freeing
2014-11-18 16:56:13 +00:00
if GAME ge 3
mov ax, si
imul ax, size PiHeader
add ax, offset pi_slot_headers
push ds
push ax
mov bx, si
shl bx, 2
[JWasm move] Avoid "push large" For 32-bit immediate values, PUSH by itself is enough. For everything else, PUSHD works in both TASM and JWasm. Also, could it be...? Could we actually move to JWasm without breaking the build in TASM at all?
2014-11-19 11:09:22 +00:00
pushd pi_slot_buffers[bx]
[Reverse-engineering] Slot-based PI file loading and freeing
2014-11-18 16:56:13 +00:00
call graph_pi_free
endif
Use TASM calling convention syntax for previously identified ZUN functions With TH03 changing the calling convention for most of the code from __cdecl to __pascal, I've been getting more and more confused about this myself. So, let's settle on the following consistent syntax for function calls: * C where the calling convention is actually __cdecl and where TASM's emitted __cdecl code matches the original binary * PASCAL where the calling convention is actually __pascal * STDCALL where the calling convention is actually __cdecl, but where the caller either defers stack cleanup (summing up the stack size of multiple functions, then cleaning it all in a single "add sp" instruction) or where the stack is cleared in a different way (e.g. "pop cx"). Unfortunately though, when using the ARG directive to automatically generate an appropriate RET instruction for the given calling convention, TASM always emits ENTER and LEAVE instructions even when no local variables are declared, which greatly limits the number of functions where we can use that syntax. -.-
2014-12-16 04:53:56 +00:00
pushd @@fn
[Reverse-engineering] Slot-based PI file loading and freeing
2014-11-18 16:56:13 +00:00
mov ax, si
imul ax, size PiHeader
add ax, offset pi_slot_headers
push ds
push ax
mov ax, si
shl ax, 2
add ax, offset pi_slot_buffers
push ds
push ax
call graph_pi_load_pack
Use TASM calling convention syntax for previously identified ZUN functions With TH03 changing the calling convention for most of the code from __cdecl to __pascal, I've been getting more and more confused about this myself. So, let's settle on the following consistent syntax for function calls: * C where the calling convention is actually __cdecl and where TASM's emitted __cdecl code matches the original binary * PASCAL where the calling convention is actually __pascal * STDCALL where the calling convention is actually __cdecl, but where the caller either defers stack cleanup (summing up the stack size of multiple functions, then cleaning it all in a single "add sp" instruction) or where the stack is cleared in a different way (e.g. "pop cx"). Unfortunately though, when using the ARG directive to automatically generate an appropriate RET instruction for the given calling convention, TASM always emits ENTER and LEAVE instructions even when no local variables are declared, which greatly limits the number of functions where we can use that syntax. -.-
2014-12-16 04:53:56 +00:00
mov @@ret, ax
[Reverse-engineering] Slot-based PI file loading and freeing
2014-11-18 16:56:13 +00:00
pop si
ret
pi_slot_load endp