751eff0edf
impr: Restore native macOS title bar double click gesture in borderless mode ( #1689 )
...
### Problem description
#### Problem 1
In borderless mode ImHex disables the standard macOS titlebar rendering
and input processing. As a result double clicking the titlebar does not
trigger the native macOS behavior set in `System Settings -> Desktop &
Dock -> Double-click a window's title bar to [Zoom/Minimize/Do
nothing]`.
#### Problem 2
The ImHex window shows up as blank/transparent when de-minimizing it
from the dock.
#### Problem 3
Widgets experience ghost hover inputs from the past position of the
cursor during live resizing.
### Implementation description
ImGui elements consume input events in the order they are drawn. As a
result by "drawing" an `InvisibleButton` over the content area of the
titlebar we can catch unprocessed clicks in the titlebar area.
Connecting this button's double clicks to the native window is then a
trivial endeavour.
The blank windows was caused by the rendering stack clearing the GL
buffer, but proceeding to draw nothing in it. I have short circuited
this path.
Ghost hover inputs were squelched by consistently moving the ImGui
cursor to `0, 0` during a live resize. The OS will dispatch a cursor
positioning event once the resizing ends, restoring normal behavior.
### Screenshots
N/A
### Additional things
N/A
---------
Co-authored-by: Nik <werwolv98@gmail.com>
2024-05-20 11:27:57 +02:00
2cb673fd81
impr: Stop rubber banding while resizing on macOS ( #1690 )
...
### Problem description
On macOS `glfwSetWindowSizeCallback` is invoked early during window
resizing, rendering a frame in that callback leads to wonky results as
the new framebuffer is swapped before the OS has the chance to actually
resize the window:
https://github.com/WerWolv/ImHex/assets/1068675/46336419-3fc2-4aa1-b16f-68b0c00e3584
### Implementation description
Window contents are redrawn only from `glfwSetWindowRefreshCallback`
during resizing, fixing the issue:
https://github.com/WerWolv/ImHex/assets/1068675/3acc5d4a-b2a5-42f0-9015-5e7172a027cf
2024-05-19 14:14:57 +02:00
125d6a3e2a
fix: Settings not being written anymore after restart
2024-05-18 20:32:34 +02:00
7a14e3dac4
fix: Wayland error discarding build errors with older GLFW versions
2024-05-17 20:22:55 +02:00
85fa1b2122
fix: Log spam on Wayland
2024-05-17 09:26:13 +02:00
ca17054a1e
impr: Store settings and achievements immediately
2024-05-15 18:27:09 +02:00
ea0cafa229
fix: Not being able to close certain modal popups with the close button on the title bar ( #1659 )
...
### Problem description
When the close button is clicked, `ImGui::BeginPopupModal()` sets the
bool passed into the second parameter (p_open) to false. However, the
closing logic did not take this into account, making it difficult to
actually close modal popups.
For example, closing the "Export pattern File" modal took several clicks
on the "X" button, now it closes instantly.
### Implementation description
I added an additional check for the `open` variable being `false` in the
logic that checks the closing condition.
2024-05-09 17:49:31 +02:00
978fa17932
impr: Make accept pattern popup open faster and close correctly
2024-05-08 23:54:09 +02:00
89f360d1a7
fix: Texture multisampling being used on OpenGL < 3.2
...
#1653
2024-05-08 22:09:47 +02:00
19c02be673
impr: Only store paths with forward slashes in project files
...
Fixes #1657
2024-05-08 21:30:20 +02:00
2994e69c08
impr: Refactor GLFW window hints into individual window files
2024-05-03 21:39:31 +02:00
6fbbf899b0
fix: Frame rate getting unlocked when inputs are being processed ( #1632 )
...
### Problem description
The framerate limiter doesn't work when inputs are being sent (eg mouse
cursor moving over the window), because `glfwWaitEventsTimeout` returns
early when it encounters an event.
### Implementation description
I made it sleep for the remaining time when that happens.
2024-05-01 20:48:41 +02:00
1df0eea6c6
impr: Added support for SVG loading, improved texture loading API
2024-05-01 20:36:10 +02:00
81982aa821
impr: Make windows always fully opaque when they're not docked
2024-04-27 20:19:45 +02:00
a7033b68f7
feat: Support DWM immersive dark mode on Windows ( #1636 )
...
### Problem description
Implements support for DWM immersive dark mode.
Closes #1635 .
### Implementation description
Uses the DwmSetWindowAttribute API to enable this feature.
Documentation can be found
[here](https://learn.microsoft.com/en-us/windows/apps/desktop/modernize/apply-windows-themes#enable-a-dark-mode-title-bar-for-win32-applications ).
### Screenshots
Before:
After:
### Additional things
Nothing.
2024-04-27 10:03:44 +02:00
a1ea8dfd84
fix: Build issue again when GLFW_WAYLAND_APP_ID isn't defined
2024-04-23 21:03:04 +02:00
cc7a0db35c
fix: Build issue when GLFW_WAYLAND_APP_ID isn't defined
2024-04-21 17:04:56 +02:00
6f11873d7e
fix: Missing window icon under wayland ( #1633 )
...
<!--
Please provide as much information as possible about what your PR aims
to do.
PRs with no description will most likely be closed until more
information is provided.
If you're planing on changing fundamental behaviour or add big new
features, please open a GitHub Issue first before starting to work on
it.
If it's not something big and you still want to contact us about it,
feel free to do so !
-->
### Problem description
When running ImHex under Wayland, the window icon is missing.
### Implementation description
Setting
[```GLFW_WAYLAND_APP_ID```](https://www.glfw.org/docs/latest/group__window.html#gafbf1ce7a4362c75e602a4df9e1bdecd3 )
to fix the issue.
### Screenshots
Before:
After:
### Additional things
<!-- Anything else you would like to say -->
2024-04-21 12:24:20 +02:00
5f75c8684f
impr: Better UI for the case when no plugins could be loaded
2024-04-10 21:04:57 +02:00
dd5ddbcc0f
fix: Settings being overwritten sometimes on crash
2024-03-26 19:49:10 +01:00
f587710d1c
fix: Multiple memory corruption issues
2024-03-26 19:49:10 +01:00
4916e5542a
fix: Splash screen being scaled incorrectly
2024-03-22 17:52:10 +01:00
9236b92dc1
fix: Memory leak when closing ImHex
2024-03-21 21:39:29 +01:00
e56b34f174
build: Mark tryDemangle as [[maybe_unused]] ( #1606 )
2024-03-21 13:33:23 +01:00
ca78c4c2fc
fix: Build errors when stacktrace headers are not present
2024-03-16 14:59:05 +01:00
a1437658af
impr: Generate more useful stack traces on Linux
2024-03-15 17:53:12 +01:00
f4ec69021d
impr: Manually implement VSync because GPU manufacturers are terrible at writing drivers
2024-03-14 21:18:57 +01:00
95da957f73
impr: Try to improve framerate limiting once more
2024-03-14 19:56:09 +01:00
2c711ea206
feat: Load additional libraries from ImHex's /lib folder
2024-03-13 19:49:04 +01:00
9b1417f32d
fix: ImHex using a ton of CPU power on Linux
2024-03-12 09:06:58 +01:00
90e93492a7
fix: Updater not working correctly on Windows
2024-03-02 17:42:02 +01:00
8f3f941600
impr: Prevent ImHex from getting stuck in an infinite crash loop
2024-03-02 09:52:09 +01:00
296af748ee
fix: Platform window not being updated when recovering from a crash
2024-03-01 20:55:03 +01:00
97f5175c84
impr: Better recovery from exceptions thrown in main thread ( #1577 )
...
This PR improves many things which can be seen by the commit name, but
the most important thing is the addition of a popup telling the user
when an exception is thrown
2024-03-01 18:21:15 +01:00
dd62bee264
build: Added precompiled headers
2024-02-29 19:57:20 +01:00
dc1a5a860c
fix: Buggy window detachment
2024-02-28 20:36:22 +01:00
f7b431902d
fix: Make sure glfw waits properly on Wayland
2024-02-28 20:16:15 +01:00
686d47a59e
fix: Frame limiting not working correctly on Linux
2024-02-28 18:48:01 +01:00
e1795d687f
impr: Implement a better algorithm to determine if the frame content has changed
2024-02-27 18:55:18 +01:00
ec69849749
feat: Added font picker to the settings ( #1570 )
2024-02-24 22:46:52 +01:00
393bea6d4b
impr: Don't pass unique_ptr by const reference
2024-02-24 15:06:28 +01:00
91dcfefc5c
fix: Crash when recovering from a thrown exception in the main thread
2024-02-23 17:48:23 +01:00
adc51d3773
fix: Crash when restarting ImHex more than once
2024-02-19 22:06:46 +01:00
01c934f53a
impr: Rework setting change listeners
2024-02-18 11:29:18 +01:00
ed292a1e7a
impr: Implement basic exception catching in main thread
2024-02-18 02:12:57 +01:00
5cfcca0bc4
feat: Allow switching off borderless window mode
2024-02-11 14:12:14 +01:00
daf4e5cad6
refactor: More cleanup of the main file
2024-02-11 13:46:06 +01:00
5d405b4d10
build: Updated GLFW and OpenGL3 ImGui Backends
2024-02-11 11:44:44 +01:00
bcbcb1f23c
impr: Various web build improvements, API cleanup ( #1541 )
2024-02-10 23:31:05 +01:00
4b20e35fd2
fix: macOS window missing decoration after restart
2024-02-10 10:17:15 +01:00
David Mentler