From e529a79ddbc8dd3aa4a69f4bd19e6beafbcc01b9 Mon Sep 17 00:00:00 2001 From: WerWolv Date: Wed, 4 Jan 2023 15:50:37 +0100 Subject: [PATCH] fix: Template pattern types being placeable using right click menu --- lib/external/pattern_language | 2 +- plugins/builtin/source/content/views/view_pattern_editor.cpp | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/external/pattern_language b/lib/external/pattern_language index 4dec3adf6..b5694bea2 160000 --- a/lib/external/pattern_language +++ b/lib/external/pattern_language @@ -1 +1 @@ -Subproject commit 4dec3adf6e2a8369569d64a6fe2c46b7c09f5943 +Subproject commit b5694bea25f0a947ba5d39eacda2109482cfcf62 diff --git a/plugins/builtin/source/content/views/view_pattern_editor.cpp b/plugins/builtin/source/content/views/view_pattern_editor.cpp index e38b20d65..52fd2bf84 100644 --- a/plugins/builtin/source/content/views/view_pattern_editor.cpp +++ b/plugins/builtin/source/content/views/view_pattern_editor.cpp @@ -928,7 +928,8 @@ namespace hex::plugin::builtin { ImGui::EndMenu(); } - if (ImGui::BeginMenu("hex.builtin.view.pattern_editor.menu.edit.place_pattern.custom"_lang, !types.empty())) { + bool hasPlaceableTypes = std::any_of(types.begin(), types.end(), [](const auto &type) { return !type.second->isTemplateType(); }); + if (ImGui::BeginMenu("hex.builtin.view.pattern_editor.menu.edit.place_pattern.custom"_lang, hasPlaceableTypes)) { for (const auto &[typeName, type] : types) { if (type->isTemplateType()) continue;