impr: Added default saveAs implementation for all providers

lib/libimhex/source/providers/provider.cpp

@@ -9,6 +9,7 @@
 #include <optional>
 
 #include <hex/helpers/magic.hpp>
+#include <wolv/io/file.hpp>
 
 namespace hex::prv {
 
@@ -36,7 +37,20 @@ namespace hex::prv {
 
     void Provider::save() { }
     void Provider::saveAs(const std::fs::path &path) {
-        hex::unused(path);
+        wolv::io::File file(path, wolv::io::File::Mode::Create);
+
+        if (file.isValid()) {
+            std::vector<u8> buffer(std::min<size_t>(0xFF'FFFF, this->getActualSize()), 0x00);
+            size_t bufferSize = buffer.size();
+
+            for (u64 offset = 0; offset < this->getActualSize(); offset += bufferSize) {
+                if (bufferSize > this->getActualSize() - offset)
+                    bufferSize = this->getActualSize() - offset;
+
+                this->read(offset + this->getBaseAddress(), buffer.data(), bufferSize, true);
+                file.write(buffer.data(), bufferSize);
+            }
+        }
     }
 
     void Provider::resize(size_t newSize) {

plugins/builtin/include/content/providers/file_provider.hpp

@@ -32,7 +32,6 @@ namespace hex::plugin::builtin {
         [[nodiscard]] size_t getActualSize() const override;
 
         void save() override;
-        void saveAs(const std::fs::path &path) override;
 
         [[nodiscard]] std::string getName() const override;
         [[nodiscard]] std::vector<std::pair<std::string, std::string>> getDataDescription() const override;

plugins/builtin/include/content/providers/gdb_provider.hpp

@@ -30,7 +30,6 @@ namespace hex::plugin::builtin {
         [[nodiscard]] size_t getActualSize() const override;
 
         void save() override;
-        void saveAs(const std::fs::path &path) override;
 
         [[nodiscard]] std::string getName() const override;
         [[nodiscard]] std::vector<std::pair<std::string, std::string>> getDataDescription() const override;

plugins/builtin/include/content/providers/memory_file_provider.hpp

@@ -28,7 +28,6 @@ namespace hex::plugin::builtin {
         void remove(u64 offset, size_t size) override;
 
         void save() override;
-        void saveAs(const std::fs::path &path) override;
 
         [[nodiscard]] std::string getName() const override { return LangEntry("hex.builtin.provider.mem_file.unsaved"); }
         [[nodiscard]] std::vector<std::pair<std::string, std::string>> getDataDescription() const override { return { }; }

plugins/builtin/source/content/providers/file_provider.cpp

@@ -91,25 +91,6 @@ namespace hex::plugin::builtin {
         this->applyPatches();
     }
 
-    void FileProvider::saveAs(const std::fs::path &path) {
-        wolv::io::File file(path, wolv::io::File::Mode::Create);
-
-        if (file.isValid()) {
-            auto provider = ImHexApi::Provider::get();
-
-            std::vector<u8> buffer(std::min<size_t>(0xFF'FFFF, provider->getActualSize()), 0x00);
-            size_t bufferSize = buffer.size();
-
-            for (u64 offset = 0; offset < provider->getActualSize(); offset += bufferSize) {
-                if (bufferSize > provider->getActualSize() - offset)
-                    bufferSize = provider->getActualSize() - offset;
-
-                provider->read(offset + this->getBaseAddress(), buffer.data(), bufferSize);
-                file.write(buffer.data(), bufferSize);
-            }
-        }
-    }
-
     void FileProvider::resize(size_t newSize) {
         this->close();
 

plugins/builtin/source/content/providers/gdb_provider.cpp

@@ -221,10 +221,6 @@ namespace hex::plugin::builtin {
         this->applyPatches();
     }
 
-    void GDBProvider::saveAs(const std::fs::path &path) {
-        hex::unused(path);
-    }
-
     size_t GDBProvider::getActualSize() const {
         return this->m_size;
     }

plugins/builtin/source/content/providers/memory_file_provider.cpp

@@ -50,25 +50,6 @@ namespace hex::plugin::builtin {
         });
     }
 
-    void MemoryFileProvider::saveAs(const std::fs::path &path) {
-        wolv::io::File file(path, wolv::io::File::Mode::Create);
-
-        if (file.isValid()) {
-            auto provider = ImHexApi::Provider::get();
-
-            std::vector<u8> buffer(std::min<size_t>(0xFF'FFFF, provider->getActualSize()), 0x00);
-            size_t bufferSize = buffer.size();
-
-            for (u64 offset = 0; offset < provider->getActualSize(); offset += bufferSize) {
-                if (bufferSize > provider->getActualSize() - offset)
-                    bufferSize = provider->getActualSize() - offset;
-
-                provider->read(offset + this->getBaseAddress(), buffer.data(), bufferSize);
-                file.write(buffer);
-            }
-        }
-    }
-
     void MemoryFileProvider::resize(size_t newSize) {
         this->m_data.resize(newSize);
 

plugins/windows/include/content/providers/process_memory_provider.hpp

@@ -36,7 +36,6 @@ namespace hex::plugin::windows {
         [[nodiscard]] size_t getActualSize() const override { return 0xFFFF'FFFF'FFFF;  }
 
         void save() override {}
-        void saveAs(const std::fs::path &) override {}
 
         [[nodiscard]] std::string getName() const override { return hex::format("hex.windows.provider.process_memory.name"_lang, this->m_selectedProcess != nullptr ? this->m_selectedProcess->name : ""); }
         [[nodiscard]] std::vector<std::pair<std::string, std::string>> getDataDescription() const override {