From 21d6c1326c58f3e2247cc4691522fa1381cfb8b8 Mon Sep 17 00:00:00 2001 From: WerWolv Date: Mon, 8 Jan 2024 22:34:42 +0100 Subject: [PATCH] fix: Invalid address bound check for jump-to option Fixes #1487 --- plugins/builtin/source/content/views/view_hex_editor.cpp | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/plugins/builtin/source/content/views/view_hex_editor.cpp b/plugins/builtin/source/content/views/view_hex_editor.cpp index f297c5275..2e77dd258 100644 --- a/plugins/builtin/source/content/views/view_hex_editor.cpp +++ b/plugins/builtin/source/content/views/view_hex_editor.cpp @@ -1308,15 +1308,11 @@ namespace hex::plugin::builtin { }; if (ImGui::MenuItem(hex::format("0x{:08X}", littleEndianValue).c_str(), "hex.ui.common.little_endian"_lang, false, canJumpTo(littleEndianValue))) { - if (value < provider->getBaseAddress() + provider->getActualSize()) { - ImHexApi::HexEditor::setSelection(littleEndianValue, 1); - } + ImHexApi::HexEditor::setSelection(littleEndianValue, 1); } if (ImGui::MenuItem(hex::format("0x{:08X}", bigEndianValue).c_str(), "hex.ui.common.big_endian"_lang, false, canJumpTo(bigEndianValue))) { - if (value < provider->getBaseAddress() + provider->getActualSize()) { - ImHexApi::HexEditor::setSelection(bigEndianValue, 1); - } + ImHexApi::HexEditor::setSelection(bigEndianValue, 1); } }, [] { return ImHexApi::Provider::isValid() && ImHexApi::HexEditor::isSelectionValid() && ImHexApi::HexEditor::getSelection()->getSize() <= sizeof(u64); });